Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2817693003: Android: Remove dummy test (Closed)

Created:
3 years, 8 months ago by Peter Wen
Modified:
3 years, 8 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Remove dummy test Causes errors for Android Studio projects due to wrong project structure. BUG=710865 Review-Url: https://codereview.chromium.org/2817693003 Cr-Commit-Position: refs/heads/master@{#464115} Committed: https://chromium.googlesource.com/chromium/src/+/bd3c471d10962ac815c82c845baaa74a87108329

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M components/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
D testing/android/junit/DummyTest.java View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Peter Wen
Hi John, Do you know if the recipes still need this target? If not can ...
3 years, 8 months ago (2017-04-12 15:59:33 UTC) #6
jbudorick
lgtm
3 years, 8 months ago (2017-04-12 16:06:26 UTC) #7
Peter Wen
Thanks for the review, John! +jochen@ for components/BUILD.gn OWNERS
3 years, 8 months ago (2017-04-12 16:15:10 UTC) #9
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-12 19:02:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817693003/1
3 years, 8 months ago (2017-04-12 19:35:37 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 19:49:30 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bd3c471d10962ac815c82c845baa...

Powered by Google App Engine
This is Rietveld 408576698