Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2817673004: Make MediaStreamVideoTrack::GetSettings return the track's frame rate. (Closed)

Created:
3 years, 8 months ago by Guido Urdaneta
Modified:
3 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, avayvod+watch_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org, tommi (sloooow) - chröme
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make MediaStreamVideoTrack::GetSettings return the track's frame rate. It is currently returning the underlying source's native frame rate, which might be different from the adjusted rate of the track. BUG=711273 Review-Url: https://codereview.chromium.org/2817673004 Cr-Commit-Position: refs/heads/master@{#465257} Committed: https://chromium.googlesource.com/chromium/src/+/935f9a2b54e4ac084ac81634a4a7afcd5de511bb

Patch Set 1 #

Patch Set 2 : return invalid settings when there is no source #

Patch Set 3 : Remove unnecessary comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -7 lines) Patch
M content/renderer/media/media_stream_video_source.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/media/media_stream_video_track.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/media/media_stream_video_track.cc View 1 1 chunk +9 lines, -3 lines 0 comments Download
M content/renderer/media/media_stream_video_track_unittest.cc View 1 2 3 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
Guido Urdaneta
Hi, PTAL
3 years, 8 months ago (2017-04-13 14:19:51 UTC) #5
Guido Urdaneta
hbos@: can you take a look? Moving tommi@ to cc.
3 years, 8 months ago (2017-04-18 14:14:17 UTC) #14
tommi (sloooow) - chröme
lgtm
3 years, 8 months ago (2017-04-18 15:21:41 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817673004/60001
3 years, 8 months ago (2017-04-18 15:22:38 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 16:27:04 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/935f9a2b54e4ac084ac81634a4a7...

Powered by Google App Engine
This is Rietveld 408576698