android: Swallow MediaCodecList constructor exception

android: Swallow MediaCodecList constructor exception

Bad android implementation can sometimes throw exceptions. Just swallow
it and pretend MediaCodecList is not supported.

BUG=695248, 709631
Review-Url: https://codereview.chromium.org/2817663004
Cr-Commit-Position: refs/heads/master@{#464270}
Committed: https://chromium.googlesource.com/chromium/src/+/169f23ffda76c9c000b3ff2366a0ff9efa5abb03

[boliu, 2017-04-12 22:44:57]

boliu@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[boliu, 2017-04-12 22:44:57]

ptal

can swallow exceptions like so. concerns?

[DaleCurtis, 2017-04-13 00:07:59]

I think the concern was that if this should never occur doing this may just move
the crash elsewhere. In any case it lgtm to try.

[boliu, 2017-04-13 00:59:35]

On 2017/04/13 00:07:59, DaleCurtis wrote:
> I think the concern was that if this should never occur doing this may just
move
> the crash elsewhere. In any case it lgtm to try.

Hmm, that's a good point. This comes from GetCapabilities, so does this
(partially?) cover crbug.com/709631 as well? I guess if the "subsequent" code
runs less frequently instead of every time a context is created, then that could
still be a net positive for crashes.

[DaleCurtis, 2017-04-13 01:15:57]

On 2017/04/13 at 00:59:35, boliu wrote:
> On 2017/04/13 00:07:59, DaleCurtis wrote:
> > I think the concern was that if this should never occur doing this may just
move
> > the crash elsewhere. In any case it lgtm to try.
> 
> Hmm, that's a good point. This comes from GetCapabilities, so does this
(partially?) cover crbug.com/709631 as well? I guess if the "subsequent" code
runs less frequently instead of every time a context is created, then that could
still be a net positive for crashes.

Yes, I think deferring it until we actually attempt to use the hardware decoder
would greatly reduce the crash rate.

[boliu, 2017-04-13 01:34:13]

Description was changed from

==========
android: Swallow MediaCodecList constructor exception

Bad android implementation can sometimes throw exceptions. Just swallow
it and pretend MediaCodecList is not supported.

BUG=695248
==========

to

==========
android: Swallow MediaCodecList constructor exception

Bad android implementation can sometimes throw exceptions. Just swallow
it and pretend MediaCodecList is not supported.

BUG=695248, 709631
==========

[boliu, 2017-04-13 01:34:54]

err, meant to say, added 709631 to bug list, and submitting

[boliu, 2017-04-13 01:35:01]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2017-04-13 01:35:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 03:18:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492047301240140, "parent_rev":
"ace0d4cd1d5616bd8ea03ce8ed314857c15d4b3a", "commit_rev":
"169f23ffda76c9c000b3ff2366a0ff9efa5abb03"}

[commit-bot: I haz the power, 2017-04-13 03:19:59]

Description was changed from

==========
android: Swallow MediaCodecList constructor exception

Bad android implementation can sometimes throw exceptions. Just swallow
it and pretend MediaCodecList is not supported.

BUG=695248, 709631
==========

to

==========
android: Swallow MediaCodecList constructor exception

Bad android implementation can sometimes throw exceptions. Just swallow
it and pretend MediaCodecList is not supported.

BUG=695248, 709631

Review-Url: https://codereview.chromium.org/2817663004
Cr-Commit-Position: refs/heads/master@{#464270}
Committed:
https://chromium.googlesource.com/chromium/src/+/169f23ffda76c9c000b3ff2366a0...
==========

[commit-bot: I haz the power, 2017-04-13 03:20:00]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/169f23ffda76c9c000b3ff2366a0...