Revert "[turbofan] Avoid going through ArgumentsAdaptorTrampoline for CSA/C++ builtins."

Revert "[turbofan] Avoid going through ArgumentsAdaptorTrampoline for CSA/C++ builtins."

This reverts commit 9df5674bd53b4a262e72f45263df9e886842c269 because it
is not compatible with the way that Array.prototype.reduceRight and
Array.prototype.reduce deal with optional parameters at this point (i.e.
parameters where the behavior is different depending on whether the
parameter was skipped or undefined was passed).

In general, it might be better to not adapt arguments for builtins with
optional paramters, that are likely skipped, for example as in
Object.create or Array.prototype.reduce. Since that will require
arguments adaptor frames for normal calls, especially from baseline
code. Instead it might make sense to use the variadic arguments support
in the CodeStubAssembler instead to avoid the arguments adaptor in all
cases (not only when called from TurboFan optimized code).

BUG=v8:5267, chromium:709782, chromium:707992, chromium:708282, chromium:708599, chromium:709173, chromium:709747, chromium:707065, chromium:710417
TBR=danno@chromium.org

Review-Url: https://codereview.chromium.org/2817653002
Cr-Commit-Position: refs/heads/master@{#44593}
Committed: https://chromium.googlesource.com/v8/v8/+/d98dfd8b9b68635c3b974e1d91be414304dec35c

[Benedikt Meurer, 2017-04-12 04:07:58]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 04:08:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-04-12 04:08:34]

machenbach: FYI

[Benedikt Meurer, 2017-04-12 04:08:39]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2017-04-12 04:08:44]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2017-04-12 04:08:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 04:32:06]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491970124105560, "parent_rev":
"7829af3275ff4644a2d0a1270abe1a1e4415e9fb", "commit_rev":
"d98dfd8b9b68635c3b974e1d91be414304dec35c"}

[commit-bot: I haz the power, 2017-04-12 04:32:12]

Description was changed from

==========
Revert "[turbofan] Avoid going through ArgumentsAdaptorTrampoline for CSA/C++
builtins."

This reverts commit 9df5674bd53b4a262e72f45263df9e886842c269 because it
is not compatible with the way that Array.prototype.reduceRight and
Array.prototype.reduce deal with optional parameters at this point (i.e.
parameters where the behavior is different depending on whether the
parameter was skipped or undefined was passed).

In general, it might be better to not adapt arguments for builtins with
optional paramters, that are likely skipped, for example as in
Object.create or Array.prototype.reduce. Since that will require
arguments adaptor frames for normal calls, especially from baseline
code. Instead it might make sense to use the variadic arguments support
in the CodeStubAssembler instead to avoid the arguments adaptor in all
cases (not only when called from TurboFan optimized code).

BUG=v8:5267,chromium:709782,chromium:707992,chromium:708282,chromium:708599,chromium:709173,chromium:709747,chromium:707065,chromium:710417
TBR=danno@chromium.org
==========

to

==========
Revert "[turbofan] Avoid going through ArgumentsAdaptorTrampoline for CSA/C++
builtins."

This reverts commit 9df5674bd53b4a262e72f45263df9e886842c269 because it
is not compatible with the way that Array.prototype.reduceRight and
Array.prototype.reduce deal with optional parameters at this point (i.e.
parameters where the behavior is different depending on whether the
parameter was skipped or undefined was passed).

In general, it might be better to not adapt arguments for builtins with
optional paramters, that are likely skipped, for example as in
Object.create or Array.prototype.reduce. Since that will require
arguments adaptor frames for normal calls, especially from baseline
code. Instead it might make sense to use the variadic arguments support
in the CodeStubAssembler instead to avoid the arguments adaptor in all
cases (not only when called from TurboFan optimized code).

BUG=v8:5267,chromium:709782,chromium:707992,chromium:708282,chromium:708599,chromium:709173,chromium:709747,chromium:707065,chromium:710417
TBR=danno@chromium.org

Review-Url: https://codereview.chromium.org/2817653002
Cr-Commit-Position: refs/heads/master@{#44593}
Committed:
https://chromium.googlesource.com/v8/v8/+/d98dfd8b9b68635c3b974e1d91be414304d...
==========

[commit-bot: I haz the power, 2017-04-12 04:32:14]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d98dfd8b9b68635c3b974e1d91be414304d...

[Michael Achenbach, 2017-04-12 07:45:50]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2017-04-12 07:45:50]

lgtm

[danno, 2017-04-12 08:04:16]

lgtm