chrome/browser/chromeos/policy/device_local_account_policy_store.cc - Issue 2817643002: Make CloudPolicyValidator memory management clearer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/device_local_account_policy_store.cc

Issue 2817643002: Make CloudPolicyValidator memory management clearer (Closed)

Patch Set: Cleaner memory management in CloudPolicyValidator Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc ('k') | chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc » ('j') | components/policy/core/common/cloud/cloud_policy_validator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/device_local_account_policy_store.cc

diff --git a/chrome/browser/chromeos/policy/device_local_account_policy_store.cc b/chrome/browser/chromeos/policy/device_local_account_policy_store.cc

index 31f42df64268d730dab40792c82127a1b18fd5f1..7bb6c4b9949b1ff693796da27ea66d482baf6aac 100644

--- a/chrome/browser/chromeos/policy/device_local_account_policy_store.cc

+++ b/chrome/browser/chromeos/policy/device_local_account_policy_store.cc

@@ -212,10 +212,8 @@ void DeviceLocalAccountPolicyStore::Validate(

validator->ValidateSignature(key->as_string());

if (validate_in_background) {

- // The Validator will delete itself once validation is

- // complete.

- validator.release()->StartValidation(

- base::Bind(callback, key->as_string()));

+ UserCloudPolicyValidator::StartValidation(

+ std::move(validator), base::Bind(callback, key->as_string()));

} else {

validator->RunValidation();