Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: chrome/browser/chromeos/policy/device_local_account_policy_store.cc

Issue 2817643002: Make CloudPolicyValidator memory management clearer (Closed)
Patch Set: Cleaner memory management in CloudPolicyValidator Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/policy/device_local_account_policy_store.h" 5 #include "chrome/browser/chromeos/policy/device_local_account_policy_store.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 CloudPolicyValidatorBase::DM_TOKEN_REQUIRED); 205 CloudPolicyValidatorBase::DM_TOKEN_REQUIRED);
206 206
207 // Validate the device id to match what device policy has. 207 // Validate the device id to match what device policy has.
208 validator->ValidateDeviceId(device_policy_data->device_id(), 208 validator->ValidateDeviceId(device_policy_data->device_id(),
209 CloudPolicyValidatorBase::DEVICE_ID_REQUIRED); 209 CloudPolicyValidatorBase::DEVICE_ID_REQUIRED);
210 210
211 validator->ValidatePayload(); 211 validator->ValidatePayload();
212 validator->ValidateSignature(key->as_string()); 212 validator->ValidateSignature(key->as_string());
213 213
214 if (validate_in_background) { 214 if (validate_in_background) {
215 // The Validator will delete itself once validation is 215 UserCloudPolicyValidator::StartValidation(
216 // complete. 216 std::move(validator), base::Bind(callback, key->as_string()));
217 validator.release()->StartValidation(
218 base::Bind(callback, key->as_string()));
219 } else { 217 } else {
220 validator->RunValidation(); 218 validator->RunValidation();
221 219
222 UpdatePolicy(key->as_string(), validator.get()); 220 UpdatePolicy(key->as_string(), validator.get());
223 } 221 }
224 } 222 }
225 223
226 } // namespace policy 224 } // namespace policy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698