MD Settings: Internet: IP Settings: Only set to static on change

MD Settings: Internet: IP Settings: Only set to static on change

Currently we set the mode to static before changing any properties.
This may result in an invalid configuration that will be rejected,
reverting back to automatic. 

This CL:
* Only sets the IPConfig mode to static when a property is changed.
* Fixes a case where IP config state was incorrectly sent on page load when networkProperties is incomplete.
* Cleans up some functions in internet_detail_page.js to avoid potential dom-if pitfalls when using |this.foo| instead of |foo| inside a bound getter. (Also to improve consistency within the file).

BUG=704631
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2817613002
Cr-Commit-Position: refs/heads/master@{#464274}
Committed: https://chromium.googlesource.com/chromium/src/+/c8c17a113a396c2080658a9a7d06c30bc8c5dba4

[stevenjb, 2017-04-12 00:39:45]

Description was changed from

==========
MD Settings: Internet: IP Settings: Only set to static on change

Currently we set the mode to static before changing any properties.
This may result in an invalid configuration that will be rejected,
reverting back to automatic. This CL only sets the mode to static
when a property is changed.

BUG=704631
==========

to

==========
MD Settings: Internet: IP Settings: Only set to static on change

Currently we set the mode to static before changing any properties.
This may result in an invalid configuration that will be rejected,
reverting back to automatic. This CL only sets the mode to static
when a property is changed.

BUG=704631
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-04-12 16:29:36]

Description was changed from

==========
MD Settings: Internet: IP Settings: Only set to static on change

Currently we set the mode to static before changing any properties.
This may result in an invalid configuration that will be rejected,
reverting back to automatic. This CL only sets the mode to static
when a property is changed.

BUG=704631
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Internet: IP Settings: Only set to static on change

Currently we set the mode to static before changing any properties.
This may result in an invalid configuration that will be rejected,
reverting back to automatic. 

This CL:
* Only sets the IPConfig mode to static when a property is changed.
* Fixes a case where IP config state was incorrectly sent on page load when
networkProperties is incomplete.
* Cleans up some functions in internet_detail_page.js to avoid potential dom-if
pitfalls when using |this.foo| instead of |foo| inside a bound getter.

BUG=704631
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-04-12 16:30:00]

Description was changed from

==========
MD Settings: Internet: IP Settings: Only set to static on change

Currently we set the mode to static before changing any properties.
This may result in an invalid configuration that will be rejected,
reverting back to automatic. 

This CL:
* Only sets the IPConfig mode to static when a property is changed.
* Fixes a case where IP config state was incorrectly sent on page load when
networkProperties is incomplete.
* Cleans up some functions in internet_detail_page.js to avoid potential dom-if
pitfalls when using |this.foo| instead of |foo| inside a bound getter.

BUG=704631
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Internet: IP Settings: Only set to static on change

Currently we set the mode to static before changing any properties.
This may result in an invalid configuration that will be rejected,
reverting back to automatic. 

This CL:
* Only sets the IPConfig mode to static when a property is changed.
* Fixes a case where IP config state was incorrectly sent on page load when
networkProperties is incomplete.
* Cleans up some functions in internet_detail_page.js to avoid potential dom-if
pitfalls when using |this.foo| instead of |foo| inside a bound getter. (Also to
improve consistency within the file).

BUG=704631
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-04-12 16:30:08]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2017-04-12 23:35:18]

https://codereview.chromium.org/2817613002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_ip_config.js
(right):

https://codereview.chromium.org/2817613002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_ip_config.js:122: //
Only fire ip-change wehn switching to automatic. Changing to static IP
"when"

https://codereview.chromium.org/2817613002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_ip_config.js:124: if
(this.automatic_) {
the early return on 108 suggests this is never false, though. Same question for
the old code on 110.

[stevenjb, 2017-04-13 00:04:47]

PTAL

https://codereview.chromium.org/2817613002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_ip_config.js
(right):

https://codereview.chromium.org/2817613002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_ip_config.js:122: //
Only fire ip-change wehn switching to automatic. Changing to static IP
On 2017/04/12 23:35:18, michaelpg wrote:
> "when"

Done.

https://codereview.chromium.org/2817613002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_ip_config.js:124: if
(this.automatic_) {
On 2017/04/12 23:35:18, michaelpg wrote:
> the early return on 108 suggests this is never false, though. Same question
for
> the old code on 110.

You're right. There's a bunch of dead / unnecessary code here. Removed and added
a comment.

[michaelpg, 2017-04-13 00:49:08]

lgtm

[stevenjb, 2017-04-13 01:00:29]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-04-13 01:01:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 03:25:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492045229499320,
"parent_rev": "f3d080598d0e371fb134baaf3f4439b6dd2d8a98", "commit_rev":
"c8c17a113a396c2080658a9a7d06c30bc8c5dba4"}

[commit-bot: I haz the power, 2017-04-13 03:26:34]

Description was changed from

==========
MD Settings: Internet: IP Settings: Only set to static on change

Currently we set the mode to static before changing any properties.
This may result in an invalid configuration that will be rejected,
reverting back to automatic. 

This CL:
* Only sets the IPConfig mode to static when a property is changed.
* Fixes a case where IP config state was incorrectly sent on page load when
networkProperties is incomplete.
* Cleans up some functions in internet_detail_page.js to avoid potential dom-if
pitfalls when using |this.foo| instead of |foo| inside a bound getter. (Also to
improve consistency within the file).

BUG=704631
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Internet: IP Settings: Only set to static on change

Currently we set the mode to static before changing any properties.
This may result in an invalid configuration that will be rejected,
reverting back to automatic. 

This CL:
* Only sets the IPConfig mode to static when a property is changed.
* Fixes a case where IP config state was incorrectly sent on page load when
networkProperties is incomplete.
* Cleans up some functions in internet_detail_page.js to avoid potential dom-if
pitfalls when using |this.foo| instead of |foo| inside a bound getter. (Also to
improve consistency within the file).

BUG=704631
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2817613002
Cr-Commit-Position: refs/heads/master@{#464274}
Committed:
https://chromium.googlesource.com/chromium/src/+/c8c17a113a396c2080658a9a7d06...
==========

[commit-bot: I haz the power, 2017-04-13 03:26:35]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c8c17a113a396c2080658a9a7d06...