Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2817603004: Throttle frames in OffscreenCanvasFrameDispatcherImpl (Closed)

Created:
3 years, 8 months ago by Justin Novosad
Modified:
3 years, 8 months ago
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, fmalita+watch_chromium.org, Rik, Justin Novosad, blink-reviews, kinuko+watch, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Throttle frames in OffscreenCanvasFrameDispatcherImpl Propagate gpu/compositor backpressure. This prevents the browser from hanging when OffscreenCanvas animations cannot render at 60fps because they are GPU bound. This change Makes OffscreenCanvas ignore the BeginFrame signal when backpressure is detected. It uses the call to OffscreenCanvasFrameDispatcherImpl::DidReceiveCompositorFrameAck as a signal to unblock the next animation frame. BUG=708709 Review-Url: https://codereview.chromium.org/2817603004 Cr-Commit-Position: refs/heads/master@{#464177} Committed: https://chromium.googlesource.com/chromium/src/+/b4efc8c9a47145a0d44414db4a6942d31bbde2c8

Patch Set 1 #

Patch Set 2 : move comment to right position #

Total comments: 1

Patch Set 3 : Remove obsolete comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp View 1 2 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 19 (14 generated)
Justin Novosad
PTAL
3 years, 8 months ago (2017-04-12 17:42:16 UTC) #6
Eric Seckler
lgtm % nit https://codereview.chromium.org/2817603004/diff/20001/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp File third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp (right): https://codereview.chromium.org/2817603004/diff/20001/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp#newcode410 third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp:410: // TODO(fsamuel): Implement this. Is there ...
3 years, 8 months ago (2017-04-12 19:39:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817603004/40001
3 years, 8 months ago (2017-04-12 20:30:48 UTC) #15
Fady Samuel
lgtm
3 years, 8 months ago (2017-04-12 21:13:16 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 22:31:00 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b4efc8c9a47145a0d44414db4a69...

Powered by Google App Engine
This is Rietveld 408576698