ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc - Issue 2817603003: Remove ListValue::Append(raw ptr) on Mac and iOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc

Issue 2817603003: Remove ListValue::Append(raw ptr) on Mac and iOS (Closed)

Patch Set: Comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc

diff --git a/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc b/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc

index 4a136416c31d2eb21477d4f99ac8c7da66751e4a..7b889fc5617125ae2edfbcd55f83307216a61b77 100644

--- a/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc

+++ b/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc

@@ -125,7 +125,7 @@ void SyncInternalsMessageHandler::HandleRequestListOfTypes(

ModelTypeSet protocol_types = syncer::ProtocolTypes();

for (ModelTypeSet::Iterator it = protocol_types.First(); it.Good();

it.Inc()) {

- type_list->Append(new base::Value(ModelTypeToString(it.Get())));

+ type_list->AppendString(ModelTypeToString(it.Get()));

}

event_details.Set(syncer::sync_ui_util::kTypes, type_list.release());

web_ui()->CallJavascriptFunction(

« no previous file with comments | « ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm ('k') | no next file » | no next file with comments »