ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm - Issue 2817603003: Remove ListValue::Append(raw ptr) on Mac and iOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm

Issue 2817603003: Remove ListValue::Append(raw ptr) on Mac and iOS (Closed)

Patch Set: Comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/passwords/password_controller.mm ('k') | ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm

diff --git a/ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm b/ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm

index db548f635bed35228e6876b996dfba87d017434c..dd9d8cd05414d3243a50847b3f8225a3af782a57 100644

--- a/ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm

+++ b/ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm

@@ -281,8 +281,7 @@ typedef NS_ENUM(NSInteger, ItemType) {

// wildcard pattern. So only show settings that the user is able to modify.

if (entries[i].secondary_pattern == ContentSettingsPattern::Wildcard() &&

entries[i].setting == CONTENT_SETTING_ALLOW) {

- _exceptions.Append(

- new base::Value(entries[i].primary_pattern.ToString()));

+ _exceptions.AppendString(entries[i].primary_pattern.ToString());

} else {

LOG(ERROR) << "Secondary content settings patterns are not "

<< "supported by the content settings UI";