Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: ios/chrome/browser/passwords/password_controller.mm

Issue 2817603003: Remove ListValue::Append(raw ptr) on Mac and iOS (Closed)
Patch Set: Comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/passwords/password_controller.mm
diff --git a/ios/chrome/browser/passwords/password_controller.mm b/ios/chrome/browser/passwords/password_controller.mm
index d79a421bdae18414272175393c1255ec3cd00ccd..2545cb32daa4731de8d79738b855fadfcc8b7946 100644
--- a/ios/chrome/browser/passwords/password_controller.mm
+++ b/ios/chrome/browser/passwords/password_controller.mm
@@ -21,6 +21,7 @@
#include "base/strings/string16.h"
#include "base/strings/sys_string_conversions.h"
#include "base/strings/utf_string_conversions.h"
+#include "base/values.h"
#include "components/autofill/core/common/password_form.h"
#include "components/autofill/core/common/password_form_fill_data.h"
#include "components/browser_sync/profile_sync_service.h"
@@ -220,14 +221,14 @@ NSString* SerializePasswordFormFillData(
auto usernameField = base::MakeUnique<base::DictionaryValue>();
usernameField->SetString("name", formData.username_field.name);
usernameField->SetString("value", formData.username_field.value);
- fieldList->Append(usernameField.release());
+ fieldList->Append(std::move(usernameField));
auto passwordField = base::MakeUnique<base::DictionaryValue>();
passwordField->SetString("name", formData.password_field.name);
passwordField->SetString("value", formData.password_field.value);
- fieldList->Append(passwordField.release());
+ fieldList->Append(std::move(passwordField));
- rootDict.Set("fields", fieldList.release());
+ rootDict.Set("fields", std::move(fieldList));
std::string jsonString;
base::JSONWriter::Write(rootDict, &jsonString);
« no previous file with comments | « content/common/font_list_mac.mm ('k') | ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698