Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: content/browser/accessibility/accessibility_tree_formatter_mac.mm

Issue 2817603003: Remove ListValue::Append(raw ptr) on Mac and iOS (Closed)
Patch Set: Comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/wifi/wifi_service_mac.mm ('k') | content/common/font_list_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/accessibility/accessibility_tree_formatter_mac.mm
diff --git a/content/browser/accessibility/accessibility_tree_formatter_mac.mm b/content/browser/accessibility/accessibility_tree_formatter_mac.mm
index 1d67d2d88fff98f17e5e28d05a9890ca8a9e1c2b..6ef7033dfec0d7f9a87d8061db564da96cefa239 100644
--- a/content/browser/accessibility/accessibility_tree_formatter_mac.mm
+++ b/content/browser/accessibility/accessibility_tree_formatter_mac.mm
@@ -12,6 +12,7 @@
#include "base/strings/stringprintf.h"
#include "base/strings/sys_string_conversions.h"
#include "base/strings/utf_string_conversions.h"
+#include "base/values.h"
#include "content/browser/accessibility/browser_accessibility_cocoa.h"
#include "content/browser/accessibility/browser_accessibility_mac.h"
#include "content/browser/accessibility/browser_accessibility_manager.h"
@@ -88,7 +89,7 @@ std::unique_ptr<base::Value> PopulateObject(id value);
std::unique_ptr<base::ListValue> PopulateArray(NSArray* array) {
std::unique_ptr<base::ListValue> list(new base::ListValue);
for (NSUInteger i = 0; i < [array count]; i++)
- list->Append(PopulateObject([array objectAtIndex:i]).release());
+ list->Append(PopulateObject([array objectAtIndex:i]));
return list;
}
@@ -253,11 +254,11 @@ void AccessibilityTreeFormatterMac::AddProperties(
if (value != nil) {
dict->Set(
SysNSStringToUTF8(requestedAttribute),
- PopulateObject(value).release());
+ PopulateObject(value));
}
}
- dict->Set(kPositionDictAttr, PopulatePosition(node).release());
- dict->Set(kSizeDictAttr, PopulateSize(cocoa_node).release());
+ dict->Set(kPositionDictAttr, PopulatePosition(node));
+ dict->Set(kSizeDictAttr, PopulateSize(cocoa_node));
}
base::string16 AccessibilityTreeFormatterMac::ToString(
« no previous file with comments | « components/wifi/wifi_service_mac.mm ('k') | content/common/font_list_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698