Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: components/wifi/wifi_service_mac.mm

Issue 2817603003: Remove ListValue::Append(raw ptr) on Mac and iOS (Closed)
Patch Set: Comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/wifi/wifi_service_mac.mm
diff --git a/components/wifi/wifi_service_mac.mm b/components/wifi/wifi_service_mac.mm
index 17ee60cf6d8952ecbfc961a95b84fe183e70e424..5b43a4af897b64f6cdb92a73f9a9972a9d22a938 100644
--- a/components/wifi/wifi_service_mac.mm
+++ b/components/wifi/wifi_service_mac.mm
@@ -8,6 +8,8 @@
#import <netinet/in.h>
#import <SystemConfiguration/SystemConfiguration.h>
+#include <utility>
+
#include "base/bind.h"
#include "base/mac/foundation_util.h"
#include "base/mac/scoped_cftyperef.h"
@@ -16,6 +18,7 @@
#include "base/macros.h"
#include "base/message_loop/message_loop.h"
#include "base/strings/sys_string_conversions.h"
+#include "base/values.h"
#include "components/onc/onc_constants.h"
#include "components/wifi/network_properties.h"
#include "crypto/apple_keychain.h"
@@ -264,7 +267,7 @@ void WiFiServiceMac::GetVisibleNetworks(const std::string& network_type,
++it) {
std::unique_ptr<base::DictionaryValue> network(
it->ToValue(!include_details));
- network_list->Append(network.release());
+ network_list->Append(std::move(network));
}
}
« no previous file with comments | « components/wifi/fake_wifi_service.cc ('k') | content/browser/accessibility/accessibility_tree_formatter_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698