Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm

Issue 2817603003: Remove ListValue::Append(raw ptr) on Mac and iOS (Closed)
Patch Set: Fix even more Mac Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm
diff --git a/ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm b/ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm
index db548f635bed35228e6876b996dfba87d017434c..65d3cb70ea2502dad327cb19fa3d574d923f8e73 100644
--- a/ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm
+++ b/ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm
@@ -8,6 +8,7 @@
#include "base/logging.h"
#import "base/mac/foundation_util.h"
#import "base/mac/scoped_nsobject.h"
+#include "base/memory/ptr_util.h"
#include "base/strings/sys_string_conversions.h"
#include "base/values.h"
#include "components/content_settings/core/browser/host_content_settings_map.h"
@@ -282,7 +283,7 @@ typedef NS_ENUM(NSInteger, ItemType) {
if (entries[i].secondary_pattern == ContentSettingsPattern::Wildcard() &&
entries[i].setting == CONTENT_SETTING_ALLOW) {
_exceptions.Append(
- new base::Value(entries[i].primary_pattern.ToString()));
+ base::MakeUnique<base::Value>(entries[i].primary_pattern.ToString()));
jdoerrie 2017/04/12 12:37:46 Consider using AppendString and removing the added
vabr (Chromium) 2017/04/12 12:55:04 Done.
} else {
LOG(ERROR) << "Secondary content settings patterns are not "
<< "supported by the content settings UI";

Powered by Google App Engine
This is Rietveld 408576698