Remove ListValue::Append(raw ptr) on Mac and iOS

ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/settings/block_popups_collection_view_controller.h"
 
 #import "base/ios/weak_nsobject.h"
 #include "base/logging.h"
 #import "base/mac/foundation_util.h"
 #import "base/mac/scoped_nsobject.h"
+#include "base/memory/ptr_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/values.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
 #include "components/content_settings/core/common/content_settings_pattern.h"
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
 #include "ios/chrome/browser/content_settings/host_content_settings_map_factory.h"
 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_switch_item.h"
 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.h"
 #import "ios/chrome/browser/ui/collection_view/collection_view_model.h"
 #import "ios/chrome/browser/ui/settings/settings_navigation_controller.h"
@@ skipping 254 matching lines @@
       continue;
     }
     // The content settings UI does not support secondary content settings
     // pattern yet. For content settings set through the content settings UI the
     // secondary pattern is by default a wildcard pattern. Hence users are not
     // able to modify content settings with a secondary pattern other than the
     // wildcard pattern. So only show settings that the user is able to modify.
     if (entries[i].secondary_pattern == ContentSettingsPattern::Wildcard() &&
         entries[i].setting == CONTENT_SETTING_ALLOW) {
       _exceptions.Append(
-          new base::Value(entries[i].primary_pattern.ToString()));
+          base::MakeUnique<base::Value>(entries[i].primary_pattern.ToString()));

[jdoerrie, 2017/04/12 12:37:46]

Consider using AppendString and removing the added #include.

[vabr (Chromium), 2017/04/12 12:55:04]

Done.

     } else {
       LOG(ERROR) << "Secondary content settings patterns are not "
                  << "supported by the content settings UI";
     }
   }
 }
 
 - (void)populateExceptionsItems {
   CollectionViewModel* model = self.collectionViewModel;
   [model addSectionWithIdentifier:SectionIdentifierExceptions];
@@ skipping 48 matching lines @@
       [[strongSelf collectionViewModel]
           removeSectionWithIdentifier:SectionIdentifierExceptions];
       [[strongSelf collectionView]
           deleteSections:[NSIndexSet indexSetWithIndex:index]];
     }
                                   completion:nil];
   }
 }
 
 @end