Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Issue 2817603002: luci-scheduler: Workaround for luci-config reporting ghost configs. (Closed)

Created:
3 years, 8 months ago by Vadim Sh.
Modified:
3 years, 8 months ago
Reviewers:
nodir
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

luci-scheduler: Workaround for luci-config reporting ghost configs. R=nodir@chromium.org BUG=710619 Review-Url: https://codereview.chromium.org/2817603002 Committed: https://github.com/luci/luci-go/commit/5d8ab084ffb1e53647bb2ced4a55e3f406f838db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M scheduler/appengine/catalog/catalog.go View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Vadim Sh.
PTAL Tested on luci-scheduler-dev, seems to be working (as in, deleted ghost jobs, kept real ...
3 years, 8 months ago (2017-04-12 00:19:29 UTC) #1
nodir
lgtm :(
3 years, 8 months ago (2017-04-12 00:41:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817603002/1
3 years, 8 months ago (2017-04-12 00:43:21 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 00:48:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/5d8ab084ffb1e53647bb2ced4a55e3f406f838db

Powered by Google App Engine
This is Rietveld 408576698