Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2817593004: [DevTools] Move eye dropper functionality from protocol to embedder (Closed)

Created:
3 years, 8 months ago by dgozman
Modified:
3 years, 8 months ago
Reviewers:
Tom Sepez, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, jam, dcheng, pfeldman+blink_chromium.org, darin-cc_chromium.org, lushnikov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move eye dropper functionality from protocol to embedder This feature does not make sense for remote debugging or automation, which suggests it's an embedder feature. BUG=none Review-Url: https://codereview.chromium.org/2817593004 Cr-Commit-Position: refs/heads/master@{#464989} Committed: https://chromium.googlesource.com/chromium/src/+/1137e62b9a4f027f2af1fa60a9dcd35e8f1043b8

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -487 lines) Patch
M chrome/browser/devtools/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_embedder_message_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_embedder_message_dispatcher.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/devtools/devtools_eye_dropper.h View 1 chunk +55 lines, -0 lines 0 comments Download
A + chrome/browser/devtools/devtools_eye_dropper.cc View 1 6 chunks +80 lines, -96 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_window.h View 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 2 chunks +24 lines, -0 lines 0 comments Download
M content/browser/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
D content/browser/devtools/protocol/color_picker.h View 1 chunk +0 lines, -57 lines 0 comments Download
D content/browser/devtools/protocol/color_picker.cc View 1 1 chunk +0 lines, -266 lines 0 comments Download
M content/browser/devtools/protocol/page_handler.h View 4 chunks +0 lines, -7 lines 0 comments Download
M content/browser/devtools/protocol/page_handler.cc View 8 chunks +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 2 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/color_picker/Spectrum.js View 1 4 chunks +11 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/devtools_compatibility.js View 2 chunks +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHost.js View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js View 1 3 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js View 1 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dgozman
Hi, could you please take a look? @Tom - devtools_embedder_message_dispatcher. I'm adding a method which ...
3 years, 8 months ago (2017-04-14 17:02:05 UTC) #5
Tom Sepez
lgtm
3 years, 8 months ago (2017-04-14 18:35:53 UTC) #6
pfeldman
lgtm
3 years, 8 months ago (2017-04-17 17:42:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817593004/20001
3 years, 8 months ago (2017-04-17 17:50:11 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 19:49:32 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1137e62b9a4f027f2af1fa60a9dc...

Powered by Google App Engine
This is Rietveld 408576698