Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2817583007: Introduce base::Value::BlobStorage typedef (Closed)

Created:
3 years, 8 months ago by jdoerrie
Modified:
3 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce base::Value::BlobStorage typedef Following the discussion on the base::Value refactor proposal document this change introduces a base::Value::BlobStorage typedef and updates exiting usages. R=brettw@chromium.org BUG=646113 Review-Url: https://codereview.chromium.org/2817583007 Cr-Commit-Position: refs/heads/master@{#465194} Committed: https://chromium.googlesource.com/chromium/src/+/5f12b627c3a67b59f3a42a3374b3255ebe1abe19

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -19 lines) Patch
M base/values.h View 1 5 chunks +6 lines, -5 lines 0 comments Download
M base/values.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M base/values_unittest.cc View 8 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
jdoerrie
Hi Brett, please review.
3 years, 8 months ago (2017-04-13 16:43:16 UTC) #3
brettw
lgtm
3 years, 8 months ago (2017-04-14 16:47:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817583007/1
3 years, 8 months ago (2017-04-18 07:01:23 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/349431) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 8 months ago (2017-04-18 07:05:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817583007/20001
3 years, 8 months ago (2017-04-18 08:43:38 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 10:22:52 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5f12b627c3a67b59f3a42a3374b3...

Powered by Google App Engine
This is Rietveld 408576698