Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2817533005: Rewrite references to "wtf/" to "platform/wtf/" in core/inspector. (Closed)

Created:
3 years, 8 months ago by Yuta Kitamura
Modified:
3 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, shans, rjwright, blink-reviews-style_chromium.org, blink-reviews-animation_chromium.org, darktears, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, Eric Willigers, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite references to "wtf/" to "platform/wtf/" in core/inspector. This is essentially the result of the following shell command followed by git cl format: find . -type f -exec sed -i 's/"wtf\//"platform\/wtf\//g' {} \; DEPS is added in order to prevent further introduction of "wtf/". Also, legacy V8 include format (like #include <v8-foo.h>) is corrected in this patch. BUG=691465 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2817533005 Cr-Commit-Position: refs/heads/master@{#464692} Committed: https://chromium.googlesource.com/chromium/src/+/923b381b904757ab4c489555759d5b8637f8d8e9

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix V8InspectorString.h. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -154 lines) Patch
M third_party/WebKit/Source/core/inspector/ConsoleMessage.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.h View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/core/inspector/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/DOMEditor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/DOMEditor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/DOMPatchSupport.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/DOMPatchSupport.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/DevToolsHost.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/IdentifiersFactory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectedFrames.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorFrontendClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHistory.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInputAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.h View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceContainer.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.h View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.h View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTaskRunner.h View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/NetworkResourcesData.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/V8InspectorString.h View 1 1 chunk +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.h View 1 chunk +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
Yuta Kitamura
dgozman: Can you look at this? For context, see my announcement in blink-dev. Thanks!
3 years, 8 months ago (2017-04-13 07:54:25 UTC) #3
dgozman
The patch says "core/frame", while it's about "core/inspector". lgtm https://codereview.chromium.org/2817533005/diff/1/third_party/WebKit/Source/core/inspector/V8InspectorString.h File third_party/WebKit/Source/core/inspector/V8InspectorString.h (right): https://codereview.chromium.org/2817533005/diff/1/third_party/WebKit/Source/core/inspector/V8InspectorString.h#newcode18 third_party/WebKit/Source/core/inspector/V8InspectorString.h:18: ...
3 years, 8 months ago (2017-04-13 17:38:11 UTC) #6
Yuta Kitamura
On 2017/04/13 17:38:11, dgozman wrote: > The patch says "core/frame", while it's about "core/inspector". Oooops! ...
3 years, 8 months ago (2017-04-14 05:16:26 UTC) #8
Yuta Kitamura
https://codereview.chromium.org/2817533005/diff/1/third_party/WebKit/Source/core/inspector/V8InspectorString.h File third_party/WebKit/Source/core/inspector/V8InspectorString.h (right): https://codereview.chromium.org/2817533005/diff/1/third_party/WebKit/Source/core/inspector/V8InspectorString.h#newcode18 third_party/WebKit/Source/core/inspector/V8InspectorString.h:18: #include "v8/include/v8-inspector.h" On 2017/04/13 17:38:11, dgozman wrote: > Move ...
3 years, 8 months ago (2017-04-14 05:16:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817533005/40001
3 years, 8 months ago (2017-04-14 05:20:16 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 06:46:22 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/923b381b904757ab4c489555759d...

Powered by Google App Engine
This is Rietveld 408576698