third_party/WebKit/Source/bindings/modules/v8/ToV8ForModules.h - Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/ToV8ForModules.h

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)

Patch Set: fixed dcheck build error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/modules/v8/ToV8ForModules.h

diff --git a/third_party/WebKit/Source/bindings/modules/v8/ToV8ForModules.h b/third_party/WebKit/Source/bindings/modules/v8/ToV8ForModules.h

index 4a22cb4d98c0eba96842ca9d5452c589d858d3af..5c5e351e231b931ddfec5c286447a2b23cac7dba 100644

--- a/third_party/WebKit/Source/bindings/modules/v8/ToV8ForModules.h

+++ b/third_party/WebKit/Source/bindings/modules/v8/ToV8ForModules.h

@@ -26,7 +26,7 @@ inline v8::Local<v8::Value> ToV8(const SQLValue& sql_value,

case SQLValue::kStringValue:

return V8String(isolate, sql_value.GetString());

}

- ASSERT_NOT_REACHED();

+ NOTREACHED();

return v8::Local<v8::Value>();

}