Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
index 20bb8b624584f581a2a22f5bb1cb1c67db4a08c8..e418d71f80cfc32acd421b446dc448d8a4a74dd4 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
@@ -162,7 +162,7 @@ void V8Window::frameElementAttributeGetterCustom(
// So, use its containing document as the creation context when wrapping.
v8::Local<v8::Value> creation_context = ToV8(
&impl->frameElement()->GetDocument(), info.Holder(), info.GetIsolate());
- RELEASE_ASSERT(!creation_context.IsEmpty());
+ CHECK(!creation_context.IsEmpty());
v8::Local<v8::Value> wrapper =
ToV8(impl->frameElement(), v8::Local<v8::Object>::Cast(creation_context),
info.GetIsolate());
@@ -189,7 +189,7 @@ void V8Window::openerAttributeSetterCustom(
if (value->IsNull()) {
// impl->frame() has to be a non-null LocalFrame. Otherwise, the
// same-origin check would have failed.
- ASSERT(impl->GetFrame());
+ DCHECK(impl->GetFrame());
ToLocalFrame(impl->GetFrame())->Loader().SetOpener(0);
}
@@ -231,7 +231,7 @@ void V8Window::postMessageMethodCustom(
// https://html.spec.whatwg.org/multipage/comms.html#dom-window-postmessage
LocalDOMWindow* source = CurrentDOMWindow(info.GetIsolate());
- ASSERT(window);
+ DCHECK(window);
UseCounter::Count(window->GetFrame(), UseCounter::kWindowPostMessage);
// If called directly by WebCore we don't have a calling context.

Powered by Google App Engine
This is Rietveld 408576698