Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ValueCache.h

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ValueCache.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ValueCache.h b/third_party/WebKit/Source/bindings/core/v8/V8ValueCache.h
index 8caa2beab9ba0dbca4bd0852cebed4c6fbb1c5d8..56f8128d86836b694f73224ade45c58526e29e51 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ValueCache.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ValueCache.h
@@ -83,7 +83,7 @@ class CORE_EXPORT StringCache {
v8::Local<v8::String> V8ExternalString(v8::Isolate* isolate,
StringImpl* string_impl) {
- ASSERT(string_impl);
+ DCHECK(string_impl);
if (last_string_impl_.Get() == string_impl)
return last_v8_string_.NewLocal(isolate);
return V8ExternalStringSlow(isolate, string_impl);
@@ -91,7 +91,7 @@ class CORE_EXPORT StringCache {
void SetReturnValueFromString(v8::ReturnValue<v8::Value> return_value,
StringImpl* string_impl) {
- ASSERT(string_impl);
+ DCHECK(string_impl);
if (last_string_impl_.Get() == string_impl)
last_v8_string_.SetReturnValue(return_value);
else

Powered by Google App Engine
This is Rietveld 408576698