Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp
index d0f5cc3748e6cb915442106af2130631f414b9b8..88045e5eb16ff8f375be25a6706e8b1e8e4e7ac6 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp
@@ -133,13 +133,13 @@ void StringCache::SetReturnValueFromStringSlow(
v8::Local<v8::String> StringCache::CreateStringAndInsertIntoCache(
v8::Isolate* isolate,
StringImpl* string_impl) {
- ASSERT(!string_cache_.Contains(string_impl));
- ASSERT(string_impl->length());
+ DCHECK(!string_cache_.Contains(string_impl));
+ DCHECK(string_impl->length());
v8::Local<v8::String> new_string =
MakeExternalString(isolate, String(string_impl));
- ASSERT(!new_string.IsEmpty());
- ASSERT(new_string->Length());
+ DCHECK(!new_string.IsEmpty());
+ DCHECK(new_string->Length());
v8::UniquePersistent<v8::String> wrapper(isolate, new_string);

Powered by Google App Engine
This is Rietveld 408576698