Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
index 7dd791596b1cf384dbec8dd295b11f45dfee11fd..e6f3e2d08e9777152705f98795855ec6532ed91f 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h
@@ -117,7 +117,7 @@ class CORE_EXPORT ScriptWrappable : public TraceWrapperBase {
WARN_UNUSED_RESULT bool SetWrapper(v8::Isolate* isolate,
const WrapperTypeInfo* wrapper_type_info,
v8::Local<v8::Object>& wrapper) {
- ASSERT(!wrapper.IsEmpty());
+ DCHECK(!wrapper.IsEmpty());
if (UNLIKELY(ContainsWrapper())) {
wrapper = MainWorldWrapper(isolate);
return false;
@@ -125,7 +125,7 @@ class CORE_EXPORT ScriptWrappable : public TraceWrapperBase {
main_world_wrapper_.Reset(isolate, wrapper);
wrapper_type_info->ConfigureWrapper(&main_world_wrapper_);
main_world_wrapper_.SetWeak();
- ASSERT(ContainsWrapper());
+ DCHECK(ContainsWrapper());
ScriptWrappableVisitor::WriteBarrier(&main_world_wrapper_);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698