third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp - Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)

Patch Set: fixed dcheck build error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp

index 1d6d4fc3bbe56e699239fea53d94a0402af6288e..044e4a58ebbbb4a1fa36c614431b3234affd4f69 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp

@@ -23,7 +23,7 @@ v8::Local<v8::Object> ScriptWrappable::Wrap(

v8::Local<v8::Object> creation_context) {

const WrapperTypeInfo* wrapper_type_info = this->GetWrapperTypeInfo();

- ASSERT(!DOMDataStore::ContainsWrapper(this, isolate));

+ DCHECK(!DOMDataStore::ContainsWrapper(this, isolate));

v8::Local<v8::Object> wrapper =

V8DOMWrapper::CreateWrapper(isolate, creation_context, wrapper_type_info);