third_party/WebKit/Source/bindings/core/v8/ScriptFunction.cpp - Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptFunction.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)

Patch Set: fixed dcheck build error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptFunction.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptFunction.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptFunction.cpp

index 9e630719a3f5bc1ddfe658bfa3094df2d3925e01..bec5937c5a980210b60056f9c64a93afc283d954 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptFunction.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptFunction.cpp

@@ -24,7 +24,7 @@ v8::Local<v8::Function> ScriptFunction::BindToV8Function() {

void ScriptFunction::CallCallback(

const v8::FunctionCallbackInfo<v8::Value>& args) {

- ASSERT(args.Data()->IsExternal());

+ DCHECK(args.Data()->IsExternal());

ScriptFunction* script_function = static_cast<ScriptFunction*>(

v8::Local<v8::External>::Cast(args.Data())->Value());

ScriptValue result = script_function->Call(