third_party/WebKit/Source/bindings/core/v8/Iterable.h - Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/Iterable.h

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)

Patch Set: fixed dcheck build error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/Iterable.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/Iterable.h b/third_party/WebKit/Source/bindings/core/v8/Iterable.h

index 689917dfca6e619f3f89d57dd4974512e28bfebe..8510f44571a5853b3225cb8483948fe4abd0e00a 100644

--- a/third_party/WebKit/Source/bindings/core/v8/Iterable.h

+++ b/third_party/WebKit/Source/bindings/core/v8/Iterable.h

@@ -71,7 +71,7 @@ class Iterable {

if (!source->Next(script_state, key, value, exception_state))

return;

- ASSERT(!exception_state.HadException());

+ DCHECK(!exception_state.HadException());

args[0] = ToV8(value, creation_context, isolate);

args[1] = ToV8(key, creation_context, isolate);