Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp b/third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp
index a075ee1c2a83dc15b8ac9c8d1b55dc89b0766fa3..979e2f168a63fb7a194cdc93761b38f42f88a931 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ExceptionMessages.cpp
@@ -145,14 +145,14 @@ String ExceptionMessages::NotEnoughArguments(unsigned expected,
}
String ExceptionMessages::NotAFiniteNumber(double value, const char* name) {
- ASSERT(!std::isfinite(value));
+ DCHECK(!std::isfinite(value));
return String::Format("The %s is %s.", name,
std::isinf(value) ? "infinite" : "not a number");
}
String ExceptionMessages::NotAFiniteNumber(const Decimal& value,
const char* name) {
- ASSERT(!value.IsFinite());
+ DCHECK(!value.IsFinite());
return String::Format("The %s is %s.", name,
value.IsInfinity() ? "infinite" : "not a number");
}

Powered by Google App Engine
This is Rietveld 408576698