Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)
Patch Set: fixed dcheck build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h b/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h
index a89d1600a0caf668d79bb29f9d5916557fc524b8..4e5e3c40718924f7901e77fd7602417ac21c2deb 100644
--- a/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h
+++ b/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h
@@ -163,8 +163,8 @@ class DOMDataStore {
static bool HolderContainsWrapper(v8::Local<v8::Object> holder,
const ScriptWrappable* wrappable) {
// Verify our assumptions about the main world.
- ASSERT(wrappable);
- ASSERT(!wrappable->ContainsWrapper() || !wrappable->IsEqualTo(holder) ||
+ DCHECK(wrappable);
+ DCHECK(!wrappable->ContainsWrapper() || !wrappable->IsEqualTo(holder) ||
Current(v8::Isolate::GetCurrent()).is_main_world_);
return wrappable->IsEqualTo(holder);
}

Powered by Google App Engine
This is Rietveld 408576698