third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp - Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp

Issue 2817533003: Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED in bindings (Closed)

Patch Set: fixed dcheck build error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp b/third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp

index 3bb73119331808a884f9eac5df782174ef75acd2..ee180e7361d10e585cb44dc0977bfe93eb025729 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp

@@ -14,7 +14,7 @@

namespace blink {

ActiveScriptWrappableBase::ActiveScriptWrappableBase() {

- ASSERT(ThreadState::Current());

+ DCHECK(ThreadState::Current());

v8::Isolate* isolate = ThreadState::Current()->GetIsolate();

V8PerIsolateData* isolate_data = V8PerIsolateData::From(isolate);

isolate_data->AddActiveScriptWrappable(this);

« no previous file with comments | « AUTHORS ('k') | third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h » ('j') | no next file with comments »