Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Issue 2817523004: Use StringPiece for TaskScheduler name. (Closed)

Created:
3 years, 8 months ago by fdoray
Modified:
3 years, 8 months ago
Reviewers:
robliao, gab
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use StringPiece for TaskScheduler name. BUG=553459 Review-Url: https://codereview.chromium.org/2817523004 Cr-Commit-Position: refs/heads/master@{#465601} Committed: https://chromium.googlesource.com/chromium/src/+/5d16e80d94adb2d8c50fec7dcfa8bfd8bbeb5895

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M base/task_scheduler/task_scheduler.h View 4 chunks +3 lines, -3 lines 0 comments Download
M base/task_scheduler/task_scheduler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/task_scheduler/task_scheduler_impl.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M base/task_scheduler/task_scheduler_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (9 generated)
fdoray
PTAL
3 years, 8 months ago (2017-04-12 19:59:24 UTC) #2
robliao
lgtm
3 years, 8 months ago (2017-04-12 20:46:28 UTC) #3
gab
lgtm https://codereview.chromium.org/2817523004/diff/1/base/task_scheduler/task_scheduler_impl.cc File base/task_scheduler/task_scheduler_impl.cc (right): https://codereview.chromium.org/2817523004/diff/1/base/task_scheduler/task_scheduler_impl.cc#newcode162 base/task_scheduler/task_scheduler_impl.cc:162: : name_(name), service_thread_("TaskSchedulerServiceThread") {} Would expect you'd need ...
3 years, 8 months ago (2017-04-13 15:34:52 UTC) #4
fdoray
https://codereview.chromium.org/2817523004/diff/1/base/task_scheduler/task_scheduler_impl.cc File base/task_scheduler/task_scheduler_impl.cc (right): https://codereview.chromium.org/2817523004/diff/1/base/task_scheduler/task_scheduler_impl.cc#newcode162 base/task_scheduler/task_scheduler_impl.cc:162: : name_(name), service_thread_("TaskSchedulerServiceThread") {} On 2017/04/13 15:34:52, gab wrote: ...
3 years, 8 months ago (2017-04-19 12:48:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817523004/20001
3 years, 8 months ago (2017-04-19 14:00:49 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 14:45:29 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5d16e80d94adb2d8c50fec7dcfa8...

Powered by Google App Engine
This is Rietveld 408576698