remoting/client/ios/host_preferences.mm - Issue 2817513004: Fixing unused keychainError var for release builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/ios/host_preferences.mm

Issue 2817513004: Fixing unused keychainError var for release builds. (Closed)

Patch Set: LOG_IF exits. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/client/ios/host_preferences.mm

diff --git a/remoting/client/ios/host_preferences.mm b/remoting/client/ios/host_preferences.mm

index f229ce25a9426dfa9f5b389092fd4d654527b2da..59ba32272ef418a241b6e4b3de939458b42421f6 100644

--- a/remoting/client/ios/host_preferences.mm

+++ b/remoting/client/ios/host_preferences.mm

@@ -44,7 +44,7 @@ static NSString* const kHostPreferencesPairSecretKey = @"PairSecret";

NSError* keychainError =

remoting::ios::WriteHostPreferencesToKeychain(writeData);

- DLOG_IF(ERROR, !keychainError) << "Could not write to keychain.";

+ LOG_IF(ERROR, !keychainError) << "Could not write to keychain.";

sdefresne 2017/04/12 15:26:28 Can't you use the "ignore_result" macro instead?

}

+ (HostPreferences*)hostForId:(NSString*)hostId {

« no previous file with comments | « no previous file | no next file » | no next file with comments »