Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2817503002:
Blink Rename follow-up: EXTsRGB should become _ext_srgb (not _ex_ts_rgb). (Closed)
|
Created:
3 years, 8 months ago by Łukasz Anforowicz Modified:
3 years, 8 months ago Reviewers:
bajones CC:
chromium-reviews, haraken, blink-reviews, dcheng Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionBlink Rename follow-up: EXTsRGB should become _ext_srgb (not _ex_ts_rgb).
The clang tool had a bug in how it processes variables named
fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz. Examples
include URLs -> ur_ls and XHRs -> xh_rs.
No intended behavior change.
BUG=675877
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2817503002
Cr-Commit-Position: refs/heads/master@{#464318}
Committed: https://chromium.googlesource.com/chromium/src/+/db535bebe4f4bc466d1c3fb74787532ade01fa71
Patch Set 1 #Patch Set 2 : Changed the spelling to ..._ext_srgb_... #
Messages
Total messages: 22 (17 generated)
Description was changed from ========== Blink Rename follow-up: EXTs --rename--> _ex_ts --this-fix--> _exts. The clang tool had a bug in how it processes variables named fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz. Examples include URLs -> ur_ls and XHRs -> xh_rs. BUG=675877 ========== to ========== Blink Rename follow-up: EXTs --rename--> _ex_ts --this-fix--> _exts. The clang tool had a bug in how it processes variables named fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz. Examples include URLs -> ur_ls and XHRs -> xh_rs. BUG=675877 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Blink Rename follow-up: EXTs --rename--> _ex_ts --this-fix--> _exts. The clang tool had a bug in how it processes variables named fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz. Examples include URLs -> ur_ls and XHRs -> xh_rs. BUG=675877 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Blink Rename follow-up: EXTs --rename--> _ex_ts --this-fix--> _exts. The clang tool had a bug in how it processes variables named fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz. Examples include URLs -> ur_ls and XHRs -> xh_rs. No intended behavior change. BUG=675877 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Blink Rename follow-up: EXTs --rename--> _ex_ts --this-fix--> _exts. The clang tool had a bug in how it processes variables named fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz. Examples include URLs -> ur_ls and XHRs -> xh_rs. No intended behavior change. BUG=675877 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Blink Rename follow-up: EXTs --big-rename--> _ex_ts --this-fix--> _exts. The clang tool had a bug in how it processes variables named fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz. Examples include URLs -> ur_ls and XHRs -> xh_rs. No intended behavior change. BUG=675877 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
lukasza@chromium.org changed reviewers: + bajones@chromium.org
bajones@, could you PTAL?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/04/11 20:15:44, Łukasz A. wrote: > bajones@, could you PTAL? These should actually be "ext_srgb", but LGTM once that change is made.
Description was changed from ========== Blink Rename follow-up: EXTs --big-rename--> _ex_ts --this-fix--> _exts. The clang tool had a bug in how it processes variables named fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz. Examples include URLs -> ur_ls and XHRs -> xh_rs. No intended behavior change. BUG=675877 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Blink Rename follow-up: EXTsRGB should become _ext_srgb (not _ex_ts_rgb). The clang tool had a bug in how it processes variables named fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz. Examples include URLs -> ur_ls and XHRs -> xh_rs. No intended behavior change. BUG=675877 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Blink Rename follow-up: EXTsRGB should become _ext_srgb (not _ex_ts_rgb). The clang tool had a bug in how it processes variables named fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz. Examples include URLs -> ur_ls and XHRs -> xh_rs. No intended behavior change. BUG=675877 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Blink Rename follow-up: EXTsRGB should become _ext_srgb (not _ex_ts_rgb). The clang tool had a bug in how it processes variables named fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz. Examples include URLs -> ur_ls and XHRs -> xh_rs. No intended behavior change. BUG=675877 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
On 2017/04/13 00:22:39, bajones wrote: > On 2017/04/11 20:15:44, Łukasz A. wrote: > > bajones@, could you PTAL? > > These should actually be "ext_srgb", but LGTM once that change is made. Great - thanks for catching my mistake here. I was too focused on fixing plural forms (URLs, XHRs) elsewhere to realize that this is meant to spell "srgb". Done.
The CQ bit was unchecked by lukasza@chromium.org
The CQ bit was checked by lukasza@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bajones@chromium.org Link to the patchset: https://codereview.chromium.org/2817503002/#ps20001 (title: "Changed the spelling to ..._ext_srgb_...")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492057029370330,
"parent_rev": "ba36ef765de08362765f726520fbe52db23faf25", "commit_rev":
"db535bebe4f4bc466d1c3fb74787532ade01fa71"}
Message was sent while issue was closed.
Description was changed from ========== Blink Rename follow-up: EXTsRGB should become _ext_srgb (not _ex_ts_rgb). The clang tool had a bug in how it processes variables named fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz. Examples include URLs -> ur_ls and XHRs -> xh_rs. No intended behavior change. BUG=675877 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Blink Rename follow-up: EXTsRGB should become _ext_srgb (not _ex_ts_rgb). The clang tool had a bug in how it processes variables named fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz. Examples include URLs -> ur_ls and XHRs -> xh_rs. No intended behavior change. BUG=675877 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2817503002 Cr-Commit-Position: refs/heads/master@{#464318} Committed: https://chromium.googlesource.com/chromium/src/+/db535bebe4f4bc466d1c3fb74787... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/db535bebe4f4bc466d1c3fb74787... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
