Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Issue 2817473002: cc: Use an enum for tracking images vetoed for async decodes. (Closed)

Created:
3 years, 8 months ago by Khushal
Modified:
3 years, 8 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Use an enum for tracking images vetoed for async decodes. This adds an option for permanent vetoes to come from blink. BUG=702386 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2817473002 Cr-Commit-Position: refs/heads/master@{#464656} Committed: https://chromium.googlesource.com/chromium/src/+/d525c83dc997c24ecd618d45c2d932cd2e7feccc

Patch Set 1 #

Total comments: 10

Patch Set 2 : addressed comments #

Total comments: 4

Patch Set 3 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -22 lines) Patch
M cc/tiles/checker_image_tracker.h View 1 2 chunks +15 lines, -5 lines 0 comments Download
M cc/tiles/checker_image_tracker.cc View 1 2 4 chunks +24 lines, -17 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Khushal
3 years, 8 months ago (2017-04-11 18:19:23 UTC) #3
vmpstr
Add some tests as well, please. https://codereview.chromium.org/2817473002/diff/1/cc/tiles/checker_image_tracker.cc File cc/tiles/checker_image_tracker.cc (right): https://codereview.chromium.org/2817473002/diff/1/cc/tiles/checker_image_tracker.cc#newcode136 cc/tiles/checker_image_tracker.cc:136: return image_async_decode_state_[image_id] == ...
3 years, 8 months ago (2017-04-11 18:42:55 UTC) #4
Khushal
The existing tests already take care of the changes. Since this change does not add ...
3 years, 8 months ago (2017-04-12 20:31:17 UTC) #5
vmpstr
lgtm https://codereview.chromium.org/2817473002/diff/20001/cc/tiles/checker_image_tracker.cc File cc/tiles/checker_image_tracker.cc (right): https://codereview.chromium.org/2817473002/diff/20001/cc/tiles/checker_image_tracker.cc#newcode130 cc/tiles/checker_image_tracker.cc:130: auto it = image_async_decode_state_.find(image_id); nit: Call ::insert() on ...
3 years, 8 months ago (2017-04-13 18:28:12 UTC) #6
Khushal
https://codereview.chromium.org/2817473002/diff/20001/cc/tiles/checker_image_tracker.cc File cc/tiles/checker_image_tracker.cc (right): https://codereview.chromium.org/2817473002/diff/20001/cc/tiles/checker_image_tracker.cc#newcode130 cc/tiles/checker_image_tracker.cc:130: auto it = image_async_decode_state_.find(image_id); On 2017/04/13 18:28:12, vmpstr wrote: ...
3 years, 8 months ago (2017-04-14 01:06:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817473002/40001
3 years, 8 months ago (2017-04-14 01:07:22 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 02:10:00 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d525c83dc997c24ecd618d45c2d9...

Powered by Google App Engine
This is Rietveld 408576698