Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2817433002: browsing_data_remover_impl: Remove dead code. (Closed)

Created:
3 years, 8 months ago by hans
Modified:
3 years, 8 months ago
Reviewers:
msramek
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

browsing_data_remover_impl: Remove dead code. Found by a Clang warning. BUG=710456 Review-Url: https://codereview.chromium.org/2817433002 Cr-Commit-Position: refs/heads/master@{#463690} Committed: https://chromium.googlesource.com/chromium/src/+/c69f6dd1905bf9e23d902634240c88f7d5e513c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M chrome/browser/browsing_data/browsing_data_remover_impl.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
hans
Please take a look.
3 years, 8 months ago (2017-04-11 17:20:47 UTC) #2
msramek
Interesting, must be a remnant of one of those datatypes that moved to the delegate ...
3 years, 8 months ago (2017-04-11 17:23:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817433002/1
3 years, 8 months ago (2017-04-11 17:24:45 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 18:24:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c69f6dd1905bf9e23d902634240c...

Powered by Google App Engine
This is Rietveld 408576698