Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2817383002: On windows call a "Native messaging host" with /D (Closed)

Created:
3 years, 8 months ago by refack
Modified:
3 years, 8 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

On windows call a "Native messaging host" with /D Without /D, cmd.exe will be executing "AutoRun commands from registry". Beside most probably them being useless in this scenario, the long running host process locks any related DLLs for no good reason BUG=711750 R=sergeyu@chromium.org Review-Url: https://codereview.chromium.org/2817383002 Cr-Commit-Position: refs/heads/master@{#465089} Committed: https://chromium.googlesource.com/chromium/src/+/50101199bf7650dc70c0c0e03e1981d4f0ee7f73

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_process_launcher_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Sergey Ulanov
I assume this is ready to review. Please next time click "Publish+Mail Comments" link when ...
3 years, 8 months ago (2017-04-18 00:33:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817383002/1
3 years, 8 months ago (2017-04-18 00:34:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/50101199bf7650dc70c0c0e03e1981d4f0ee7f73
3 years, 8 months ago (2017-04-18 01:13:31 UTC) #6
refack
3 years, 8 months ago (2017-04-18 01:26:36 UTC) #7
Message was sent while issue was closed.
On 2017/04/18 01:13:31, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/50101199bf7650dc70c0c0e03e19...

I'm a little bit excited, my first "real" chromium land :D

Powered by Google App Engine
This is Rietveld 408576698