Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: ash/system/network/network_icon.h

Issue 2817223003: Chrome OS: adjust wifi icons. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/system/network/network_icon.cc » ('j') | ash/system/network/network_icon.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/network/network_icon.h
diff --git a/ash/system/network/network_icon.h b/ash/system/network/network_icon.h
index be5bd48261ae8e94083e7a08a685f2705b098259..dec6bd3d4f72de478a922e395a45bda0b6e28c74 100644
--- a/ash/system/network/network_icon.h
+++ b/ash/system/network/network_icon.h
@@ -34,9 +34,11 @@ ASH_EXPORT gfx::ImageSkia GetImageForNetwork(
IconType icon_type);
// Gets an image for a Wi-Fi network, either full strength or strike-through
-// based on |connected|.
+// based on |enabled|.
// TODO(estade): Expose SignalStrengthImageSource and use that instead.
-ASH_EXPORT gfx::ImageSkia GetBasicImageForWiFiNetwork(bool connected);
+ASH_EXPORT gfx::ImageSkia GetImageForWiFiChipState(
stevenjb 2017/04/17 16:22:52 It is unclear to me what 'ChipState' means. Maybe
Evan Stade 2017/04/17 16:29:33 Done.
+ bool enabled,
+ IconType = ICON_TYPE_DEFAULT_VIEW);
stevenjb 2017/04/17 16:22:52 Mostly we avoid default arguments. I'd just as soo
Evan Stade 2017/04/17 16:29:33 discussed offline, leaving as is.
stevenjb 2017/04/17 16:34:11 Acknowledged.
// Gets the disconnected image for a cell network.
// TODO(estade): Expose SignalStrengthImageSource and use that instead.
« no previous file with comments | « no previous file | ash/system/network/network_icon.cc » ('j') | ash/system/network/network_icon.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698