Remove base::StackString.

Remove base::StackString.

This was only used in one place and it turns out that StackString was
broken on Windows anyway due to the way that STL reserves buffers.

BUG=709273
Review-Url: https://codereview.chromium.org/2817223002
Cr-Commit-Position: refs/heads/master@{#464764}
Committed: https://chromium.googlesource.com/chromium/src/+/eacc100de55e5b286aa8548b22c99c815cd69486

[brettw, 2017-04-14 16:16:43]

brettw@chromium.org changed reviewers:
+ sunnyps@chromium.org

[brettw, 2017-04-14 16:16:49]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 16:17:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 17:18:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 17:18:25]

Dry run: This issue passed the CQ dry run.

[sunnyps, 2017-04-14 17:27:54]

https://codereview.chromium.org/2817223002/diff/1/tools/gn/escape.cc
File tools/gn/escape.cc (right):

https://codereview.chromium.org/2817223002/diff/1/tools/gn/escape.cc#newcode205
tools/gn/escape.cc:205: EscapeStringToString(str, options, &escaped, nullptr);
EscapeStringToString and other methods don't need to be templated anymore. Can
you change those in this CL?

[brettw, 2017-04-14 17:39:49]

No template

[brettw, 2017-04-14 17:40:19]

Yeah, I was originally thinking that we would fix the static containers (at
least vector) and it could be used here, but it's pretty unlikely to happen
soon, so removing the templates is the right answer.

[brettw, 2017-04-14 17:40:24]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 17:40:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunnyps, 2017-04-14 18:04:30]

lgtm

[brettw, 2017-04-14 18:07:48]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2017-04-14 18:07:52]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2017-04-14 18:08:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 18:54:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492193272310410,
"parent_rev": "3b1c2e7db1894fcb07f104d17343fa6912be2188", "commit_rev":
"eacc100de55e5b286aa8548b22c99c815cd69486"}

[commit-bot: I haz the power, 2017-04-14 18:55:32]

Description was changed from

==========
Remove base::StackString.

This was only used in one place and it turns out that StackString was
broken on Windows anyway due to the way that STL reserves buffers.

BUG=709273
==========

to

==========
Remove base::StackString.

This was only used in one place and it turns out that StackString was
broken on Windows anyway due to the way that STL reserves buffers.

BUG=709273

Review-Url: https://codereview.chromium.org/2817223002
Cr-Commit-Position: refs/heads/master@{#464764}
Committed:
https://chromium.googlesource.com/chromium/src/+/eacc100de55e5b286aa8548b22c9...
==========

[commit-bot: I haz the power, 2017-04-14 18:55:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eacc100de55e5b286aa8548b22c9...