Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 2817083002: [MD settings] MIDI and JavaScript icons closer to page info icons (Closed)

Created:
3 years, 8 months ago by dschuyler
Modified:
3 years, 8 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] MIDI and JavaScript icons closer to page info icons This CL changes the icons for content settings of MIDI and JavaScript so that they are closer to those used in the page info dropdown (from the omnibox). BUG=709142 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2817083002 Cr-Commit-Position: refs/heads/master@{#464593} Committed: https://chromium.googlesource.com/chromium/src/+/94182b78878d55cb968e15312c66abfe21e3caf4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/resources/settings/icons.html View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_details.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings_page/site_settings_page.html View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dschuyler
Screen shots in the bug. Also, we didn't find a midi svg, so Alan drew ...
3 years, 8 months ago (2017-04-13 21:25:17 UTC) #5
tommycli
lgtm
3 years, 8 months ago (2017-04-13 21:32:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817083002/1
3 years, 8 months ago (2017-04-13 22:39:02 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 23:05:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/94182b78878d55cb968e15312c66...

Powered by Google App Engine
This is Rietveld 408576698