Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2817073003: Update description of mouse-click-plugin-clears-selection.html (Closed)

Created:
3 years, 8 months ago by hugoh_UTC2
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update description of mouse-click-plugin-clears-selection.html After crrev.com/2616623002, we now do expect the layout tree to contain a selection (a selection that is hidden). So let's update the test's inline description to reflect this exception. BUG=678601 Review-Url: https://codereview.chromium.org/2817073003 Cr-Commit-Position: refs/heads/master@{#464710} Committed: https://chromium.googlesource.com/chromium/src/+/ec55bb5f6efdd3b9db80075ccba703064eeded80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/plugins/mouse-click-plugin-clears-selection.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
hugoh_UTC2
yosin@ PTAL
3 years, 8 months ago (2017-04-14 09:10:49 UTC) #2
yosin_UTC9
lgtm Thanks for catching this!
3 years, 8 months ago (2017-04-14 09:15:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817073003/1
3 years, 8 months ago (2017-04-14 09:15:46 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 10:22:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ec55bb5f6efdd3b9db80075ccba7...

Powered by Google App Engine
This is Rietveld 408576698