Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2816973002: Revert of Move logic of recording main thread scrolling reasons from cc to blink::ScrollManager (Closed)

Created:
3 years, 8 months ago by jdoerrie
Modified:
3 years, 8 months ago
Reviewers:
ajuma, yigu, bokan, flackr, jwd, tdresser
CC:
chromium-reviews, dtapuska+blinkwatch_chromium.org, kinuko+watch, Navid Zolghadr, dtapuska+chromiumwatch_chromium.org, dshwang, blink-reviews-paint_chromium.org, blink-reviews, cc-bugs_chromium.org, blink-reviews-frames_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move logic of recording main thread scrolling reasons from cc to blink::ScrollManager (patchset #17 id:320001 of https://codereview.chromium.org/2773593005/ ) Reason for revert: Likely cause of webkit_unit_tests failing on chromium.webkit/WebKit Android (Nexus4). BUG=711190 Original issue's description: > Move logic of recording main thread scrolling reasons from cc to > blink::ScrollManager > > Due to crbug.com/701355, all style related main thread scrolling reasons > stop being recorded. This patch moves the logic of storing the style > related reasons to PLSA and move the recording logic to ScrollManager > because the information on the compositor side is insufficient. The > disabled test due to the previous bug has been enabled again with minor > modification. > > BUG=704805 > TEST=All/NonCompositedMainThreadScrollingReasonTest.*; > EventHandlerTest.NonCompositedMainThreadScrollingReason* > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2773593005 > Cr-Commit-Position: refs/heads/master@{#464073} > Committed: https://chromium.googlesource.com/chromium/src/+/76d0929033d6cd3ec36b96d1b4845166e70c9349 TBR=flackr@chromium.org,ajuma@chromium.org,bokan@chromium.org,tdresser@chromium.org,jwd@chromium.org,yigu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=704805 Review-Url: https://codereview.chromium.org/2816973002 Cr-Commit-Position: refs/heads/master@{#464337} Committed: https://chromium.googlesource.com/chromium/src/+/998f8e571bebd0ace499f8fef81f91daffada15f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -468 lines) Patch
M cc/input/main_thread_scrolling_reason.h View 5 chunks +18 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 4 chunks +27 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandlerTest.cpp View 5 chunks +0 lines, -233 lines 0 comments Download
M third_party/WebKit/Source/core/input/ScrollManager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/input/ScrollManager.cpp View 3 chunks +0 lines, -64 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 6 chunks +55 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp View 2 chunks +70 lines, -126 lines 0 comments Download
M third_party/WebKit/Source/web/tests/data/two_scrollable_area.html View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jdoerrie
Created Revert of Move logic of recording main thread scrolling reasons from cc to blink::ScrollManager
3 years, 8 months ago (2017-04-13 08:09:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816973002/1
3 years, 8 months ago (2017-04-13 08:09:47 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 08:11:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/998f8e571bebd0ace499f8fef81f...

Powered by Google App Engine
This is Rietveld 408576698