Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2816943003: Correct the android version for using file URI for download (Closed)

Created:
3 years, 8 months ago by qinmin
Modified:
3 years, 8 months ago
Reviewers:
agrieve
CC:
chromium-reviews, danakj+watch_chromium.org, agrieve+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct the android version for using file URI for download On devices <=M, clicking on a downloaded apk doesn't work as content URI is not recognized by the installer. The previous change https://codereview.chromium.org/2799533002/ only applies to devices <=J. However, the issue exists on all devices <=M. correct the android version for this. BUG=711356 Review-Url: https://codereview.chromium.org/2816943003 Cr-Commit-Position: refs/heads/master@{#464493} Committed: https://chromium.googlesource.com/chromium/src/+/c028fb577e58a2375ec0f4acc7fa6568feb9f678

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
qinmin
agrieve@, mind take a quick look at this CL?
3 years, 8 months ago (2017-04-13 17:41:42 UTC) #2
agrieve
On 2017/04/13 17:41:42, qinmin wrote: > agrieve@, mind take a quick look at this CL? ...
3 years, 8 months ago (2017-04-13 17:45:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816943003/1
3 years, 8 months ago (2017-04-13 17:46:23 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 19:14:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c028fb577e58a2375ec0f4acc7fa...

Powered by Google App Engine
This is Rietveld 408576698