Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2816913002: Add some public_deps for //headless:headless_lib. (Closed)

Created:
3 years, 8 months ago by mattm
Modified:
3 years, 8 months ago
Reviewers:
Sami
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add some public_deps for //headless:headless_lib. headless/public/util/managed_dispatch_url_request_job.h includes files from //base and //net, so they should be public dependencies. Example error: In file included from ../../headless/public/util/deterministic_dispatcher_test.cc:15: In file included from ../../headless/public/util/testing/fake_managed_dispatch_url_request_job.h:13: In file included from ../../headless/public/util/managed_dispatch_url_request_job.h:11: In file included from ../../net/url_request/url_request.h:26: In file included from ../../net/base/net_error_details.h:9: In file included from ../../net/http/http_response_info.h:14: In file included from ../../net/ssl/ssl_info.h:20: In file included from ../../net/ssl/ssl_config.h:12: In file included from ../../net/cert/x509_certificate.h:25: ../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error: 'openssl/opensslconf.h' file not found BUG=none Review-Url: https://codereview.chromium.org/2816913002 Cr-Commit-Position: refs/heads/master@{#464473} Committed: https://chromium.googlesource.com/chromium/src/+/d9848157615e65a8b8cf5e877916f97d2eb098ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M headless/BUILD.gn View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mattm
3 years, 8 months ago (2017-04-13 01:52:35 UTC) #3
Sami
lgtm, thanks!
3 years, 8 months ago (2017-04-13 09:27:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816913002/1
3 years, 8 months ago (2017-04-13 18:10:28 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 18:20:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d9848157615e65a8b8cf5e877916...

Powered by Google App Engine
This is Rietveld 408576698