Added CSSPropertyOffsetPathUtils which holds shared parsing logic.

Added CSSPropertyOffsetPathUtils which holds shared parsing logic.

This patch
- Added CSSPropertyOffsetPathUtils.
- Moved ConsumeOffsetPath, ConsumePathOrNone, and ConsumePath methods
  from CSSPropertyParser to CSSPropertyOffsetPathUtils.
- Made the ConsumePath method private to the CSSPropertyOffsetPathUtils
  file as it is not used elsewhere.

This is pre work to move ParseSingleValue logic from CSSPropertyParser
to the property API for CSSPropertyOffsetPath.

BUG=668012
Review-Url: https://codereview.chromium.org/2816903003
Cr-Commit-Position: refs/heads/master@{#465826}
Committed: https://chromium.googlesource.com/chromium/src/+/128db945e1f34ed9609cf51f7a0291a113b455ac

[Bugs Nash, 2017-04-13 06:10:43]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 06:11:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2017-04-13 06:11:37]

Description was changed from

==========
Added CSSPropertyOffsetPathUtils which holds shared parsing logic.

This patch
- Added CSSPropertyOffsetPathUtils
- Moved ConsumeOffsetPath, ConsumePathOrNone, and ConsumePath methods
  from CSSPropertyParser to CSSPropertyOffsetPathUtils

This is pre work to move ParseSingleValue logic from CSSPropertyParser
to the property API for CSSPropertyOffsetPath.

BUG=668012
==========

to

==========
Added CSSPropertyOffsetPathUtils which holds shared parsing logic.

This patch
- Added CSSPropertyOffsetPathUtils.
- Moved ConsumeOffsetPath, ConsumePathOrNone, and ConsumePath methods
  from CSSPropertyParser to CSSPropertyOffsetPathUtils.
- Made the ConsumePath method private to the CSSPropertyOffsetPathUtils
  file as it is not used elsewhere.

This is pre work to move ParseSingleValue logic from CSSPropertyParser
to the property API for CSSPropertyOffsetPath.

BUG=668012
==========

[Bugs Nash, 2017-04-13 06:12:12]

bugsnash@chromium.org changed reviewers:
+ ericwilligers@chromium.org

[commit-bot: I haz the power, 2017-04-13 08:16:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 08:16:59]

Dry run: This issue passed the CQ dry run.

[Eric Willigers, 2017-04-13 21:18:12]

lgtm

https://codereview.chromium.org/2816903003/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/css/properties/CSSPropertyOffsetPathUtils.cpp
(right):

https://codereview.chromium.org/2816903003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyOffsetPathUtils.cpp:35:
return nullptr;
I'd wrap this line in { } as the condition is spread across multiple lines.

[Bugs Nash, 2017-04-13 22:38:43]

bugsnash@chromium.org changed reviewers:
+ alancutter@chromium.org

[Bugs Nash, 2017-04-17 23:17:15]

addressed review

[Bugs Nash, 2017-04-17 23:17:22]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[Bugs Nash, 2017-04-17 23:17:36]

+alancutter for owners

https://codereview.chromium.org/2816903003/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/css/properties/CSSPropertyOffsetPathUtils.cpp
(right):

https://codereview.chromium.org/2816903003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyOffsetPathUtils.cpp:35:
return nullptr;
On 2017/04/13 at 21:18:12, Eric Willigers wrote:
> I'd wrap this line in { } as the condition is spread across multiple lines.

done

[commit-bot: I haz the power, 2017-04-17 23:17:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 01:31:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 01:31:29]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2017-04-19 06:51:32]

lgtm

[Bugs Nash, 2017-04-19 06:56:32]

The CQ bit was checked by bugsnash@chromium.org

[Bugs Nash, 2017-04-19 06:56:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/2816903003/#ps20001
(title: "addressed review")

[commit-bot: I haz the power, 2017-04-19 06:56:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 08:14:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 08:14:49]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bugs Nash, 2017-04-19 21:38:31]

The CQ bit was checked by bugsnash@chromium.org

[commit-bot: I haz the power, 2017-04-19 21:39:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2017-04-19 21:43:33]

The CQ bit was unchecked by bugsnash@chromium.org

[Bugs Nash, 2017-04-19 22:01:19]

rebased

[Bugs Nash, 2017-04-19 22:42:15]

The CQ bit was checked by bugsnash@chromium.org

[Bugs Nash, 2017-04-19 22:42:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org, ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/2816903003/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2017-04-19 22:42:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 00:36:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492641735132220,
"parent_rev": "6a3a1f8d359249a0c9abd5e9630c14a63afebf66", "commit_rev":
"128db945e1f34ed9609cf51f7a0291a113b455ac"}

[commit-bot: I haz the power, 2017-04-20 00:36:54]

Description was changed from

==========
Added CSSPropertyOffsetPathUtils which holds shared parsing logic.

This patch
- Added CSSPropertyOffsetPathUtils.
- Moved ConsumeOffsetPath, ConsumePathOrNone, and ConsumePath methods
  from CSSPropertyParser to CSSPropertyOffsetPathUtils.
- Made the ConsumePath method private to the CSSPropertyOffsetPathUtils
  file as it is not used elsewhere.

This is pre work to move ParseSingleValue logic from CSSPropertyParser
to the property API for CSSPropertyOffsetPath.

BUG=668012
==========

to

==========
Added CSSPropertyOffsetPathUtils which holds shared parsing logic.

This patch
- Added CSSPropertyOffsetPathUtils.
- Moved ConsumeOffsetPath, ConsumePathOrNone, and ConsumePath methods
  from CSSPropertyParser to CSSPropertyOffsetPathUtils.
- Made the ConsumePath method private to the CSSPropertyOffsetPathUtils
  file as it is not used elsewhere.

This is pre work to move ParseSingleValue logic from CSSPropertyParser
to the property API for CSSPropertyOffsetPath.

BUG=668012

Review-Url: https://codereview.chromium.org/2816903003
Cr-Commit-Position: refs/heads/master@{#465826}
Committed:
https://chromium.googlesource.com/chromium/src/+/128db945e1f34ed9609cf51f7a02...
==========

[commit-bot: I haz the power, 2017-04-20 00:36:55]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/128db945e1f34ed9609cf51f7a02...