Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 2816903002: Revert "[Merge to M58] Deprecate Alt+Shift+K and replace it by Search+Shift+K" (Closed)

Created:
3 years, 8 months ago by afakhry
Modified:
3 years, 8 months ago
Reviewers:
xiyuan, James Cook, Mark P
CC:
chromium-reviews, alemate+watch_chromium.org, sadrul, oshima+watch_chromium.org, arv+watch_chromium.org, asvitkine+watch_chromium.org, kalyank
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Revert "[Merge to M58] Deprecate Alt+Shift+K and replace it by Search+Shift+K" Reason: this changes strings which were frozen back in February for R58, so we don't have translations in place for 58. TBR=xiyuan@chromium.org, jamescook@chromium.org, mpearson@chromium.org BUG=706018 TEST=Alt+Shift+K should continue to work. This reverts commit 579880a51bcd7ec59e66d85d2d764a536cd06530. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2816903002 . Cr-Commit-Position: refs/branch-heads/3029@{#685} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/e42548579da70327f15bb97ad05a85bf28d76d96

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -37 lines) Patch
M ash/accelerators/accelerator_controller_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/ash_strings.grd View 2 chunks +0 lines, -10 lines 0 comments Download
M ash/common/accelerators/accelerator_table.cc View 3 chunks +3 lines, -10 lines 0 comments Download
M chrome/app/chromeos_strings.grdp View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay_data.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
afakhry
3 years, 8 months ago (2017-04-13 00:45:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e42548579da70327f15bb97ad05a85bf28d76d96 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698