Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp

Issue 2816873002: Update PaintLayer size during layout, not after.
Patch Set: Speculatively remove call to UpdateScrollbars() Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp
diff --git a/third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp b/third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp
index d05036343f558b5807d9eb91d20352eba8f0552c..a5e34c4c9d09174be99c1defe7c13f56d98e6eff 100644
--- a/third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp
+++ b/third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp
@@ -382,15 +382,8 @@ TEST_P(BoxPaintInvalidatorTest, NonCompositedLayoutViewResize) {
EXPECT_EQ(
static_cast<const DisplayItemClient*>(content->GetLayoutObject()->View()),
raster_invalidations[1].client);
- if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
- // TODO(skobes): Treat LayoutView in the same way as normal objects having
- // background-attachment: local. crbug.com/568847.
- EXPECT_EQ(IntRect(0, 0, 100, 200), raster_invalidations[1].rect);
- EXPECT_EQ(kPaintInvalidationFull, raster_invalidations[1].reason);
- } else {
- EXPECT_EQ(IntRect(0, 100, 100, 100), raster_invalidations[1].rect);
- EXPECT_EQ(kPaintInvalidationIncremental, raster_invalidations[1].reason);
- }
+ EXPECT_EQ(IntRect(0, 100, 100, 100), raster_invalidations[1].rect);
+ EXPECT_EQ(kPaintInvalidationIncremental, raster_invalidations[1].reason);
GetDocument().View()->SetTracksPaintInvalidations(false);
}
@@ -446,14 +439,8 @@ TEST_P(BoxPaintInvalidatorTest, NonCompositedLayoutViewGradientResize) {
EXPECT_EQ(static_cast<const DisplayItemClient*>(frame_layout_view),
(*raster_invalidations)[1].client);
EXPECT_EQ(IntRect(0, 0, 100, 200), (*raster_invalidations)[1].rect);
- if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
- // TODO(skobes): Treat LayoutView in the same way as normal objects having
- // background-attachment: local. crbug.com/568847.
- EXPECT_EQ(kPaintInvalidationFull, (*raster_invalidations)[1].reason);
- } else {
- EXPECT_EQ(kPaintInvalidationViewBackground,
- (*raster_invalidations)[1].reason);
- }
+ EXPECT_EQ(kPaintInvalidationViewBackground,
+ (*raster_invalidations)[1].reason);
GetDocument().View()->SetTracksPaintInvalidations(false);
}
« no previous file with comments | « third_party/WebKit/Source/core/page/ChromeClient.h ('k') | third_party/WebKit/Source/core/paint/PaintLayer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698