third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc - Issue 2816873002: Update PaintLayer size during layout, not after.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc

Issue 2816873002: Update PaintLayer size during layout, not after.

Patch Set: Speculatively remove call to UpdateScrollbars() Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "core/layout/ng/layout_ng_block_flow.h"	5 #include "core/layout/ng/layout_ng_block_flow.h"

6	6

7 #include "core/layout/LayoutAnalyzer.h"	7 #include "core/layout/LayoutAnalyzer.h"

8 #include "core/layout/ng/ng_constraint_space.h"	8 #include "core/layout/ng/ng_constraint_space.h"

9 #include "core/layout/ng/ng_fragment.h"	9 #include "core/layout/ng/ng_fragment.h"

10	10

(...skipping 29 matching lines...) Expand all Loading...
40 // NGBlockNode::CopyFragmentDataToLayoutBox.	40 // NGBlockNode::CopyFragmentDataToLayoutBox.

41 LogicalExtentComputedValues computed_values;	41 LogicalExtentComputedValues computed_values;

42 ComputeLogicalWidth(computed_values);	42 ComputeLogicalWidth(computed_values);

43 SetLogicalLeft(computed_values.position_);	43 SetLogicalLeft(computed_values.position_);

44 ComputeLogicalHeight(LogicalHeight(), LogicalTop(), computed_values);	44 ComputeLogicalHeight(LogicalHeight(), LogicalTop(), computed_values);

45 SetLogicalTop(computed_values.position_);	45 SetLogicalTop(computed_values.position_);

46 }	46 }

47	47

48 for (auto& descendant : result->OutOfFlowDescendants())	48 for (auto& descendant : result->OutOfFlowDescendants())

49 descendant->UseOldOutOfFlowPositioning();	49 descendant->UseOldOutOfFlowPositioning();

	50

	51 UpdateAfterLayout();

50 ClearNeedsLayout();	52 ClearNeedsLayout();

51 }	53 }

52	54

53 } // namespace blink	55 } // namespace blink

OLD	NEW