Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2816823002: Fixing flaky integration test (Closed)

Created:
3 years, 8 months ago by RyanSturm
Modified:
3 years, 8 months ago
Reviewers:
Robert Ogden, sclittle
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing flaky integration test BUG=700612 Review-Url: https://codereview.chromium.org/2816823002 Cr-Commit-Position: refs/heads/master@{#464207} Committed: https://chromium.googlesource.com/chromium/src/+/c37ea25b3d66e0081c0fc86c3a24e4e38c48177b

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M tools/chrome_proxy/webdriver/bypass.py View 1 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 25 (14 generated)
RyanSturm
robertogden: PTAL
3 years, 8 months ago (2017-04-12 21:45:57 UTC) #4
Robert Ogden
lgtm % assuming you ran this a handful of times and it doesn't flake?
3 years, 8 months ago (2017-04-12 22:31:09 UTC) #7
RyanSturm
On 2017/04/12 22:31:09, Robert Ogden wrote: > lgtm % assuming you ran this a handful ...
3 years, 8 months ago (2017-04-12 22:33:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816823002/1
3 years, 8 months ago (2017-04-12 22:34:45 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-12 22:34:46 UTC) #12
RyanSturm
Oops, forgot Robert wasn't an OWNER for this stuff :/ sclittle: PTAL
3 years, 8 months ago (2017-04-12 22:44:20 UTC) #14
sclittle
lgtm
3 years, 8 months ago (2017-04-12 22:49:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816823002/1
3 years, 8 months ago (2017-04-12 22:51:54 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/409770)
3 years, 8 months ago (2017-04-12 23:04:57 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2816823002/20001
3 years, 8 months ago (2017-04-12 23:14:23 UTC) #22
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 23:45:27 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c37ea25b3d66e0081c0fc86c3a24...

Powered by Google App Engine
This is Rietveld 408576698