|
|
Chromium Code Reviews
DescriptionFixing flaky integration test
BUG=700612
Review-Url: https://codereview.chromium.org/2816823002
Cr-Commit-Position: refs/heads/master@{#464207}
Committed: https://chromium.googlesource.com/chromium/src/+/c37ea25b3d66e0081c0fc86c3a24e4e38c48177b
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 25 (14 generated)
The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ryansturm@chromium.org changed reviewers: + robertogden@chromium.org
robertogden: PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm % assuming you ran this a handful of times and it doesn't flake?
On 2017/04/12 22:31:09, Robert Ogden wrote: > lgtm % assuming you ran this a handful of times and it doesn't flake? Yea. I ran it a few times. It's a pretty understandable problem with the favicon service. Unfortunately, there isn't a flag to disable the favicon service, so we have to live with it maybe using the favicon service and maybe not :/.
The CQ bit was checked by ryansturm@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
ryansturm@chromium.org changed reviewers: + sclittle@chromium.org
Oops, forgot Robert wasn't an OWNER for this stuff :/ sclittle: PTAL
lgtm
The CQ bit was checked by ryansturm@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by ryansturm@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from robertogden@chromium.org, sclittle@chromium.org Link to the patchset: https://codereview.chromium.org/2816823002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492038806876690,
"parent_rev": "da01210bc087bff3f3e9b582598e3d0bb68bd9e6", "commit_rev":
"c37ea25b3d66e0081c0fc86c3a24e4e38c48177b"}
Message was sent while issue was closed.
Description was changed from ========== Fixing flaky integration test BUG=700612 ========== to ========== Fixing flaky integration test BUG=700612 Review-Url: https://codereview.chromium.org/2816823002 Cr-Commit-Position: refs/heads/master@{#464207} Committed: https://chromium.googlesource.com/chromium/src/+/c37ea25b3d66e0081c0fc86c3a24... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/c37ea25b3d66e0081c0fc86c3a24... |
