Allow manual testing of FRE on Linux builds

Allow manual testing of FRE on Linux builds

Small refactoring of WizardController::OnNetworkConnected() to merge the
flows of official and unofficial builds as much as possible to properly
trigger FRE on a Linux build.  This is done by calling OnEulaAccepted()
on unofficial builds.

BUG=703658
Review-Url: https://codereview.chromium.org/2816763002
Cr-Commit-Position: refs/heads/master@{#464296}
Committed: https://chromium.googlesource.com/chromium/src/+/d0605bc9ca32f07f098363e0b1dc7d5a9bc075e8

[Thiemo Nagel, 2017-04-12 16:23:29]

The CQ bit was checked by tnagel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 16:23:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 17:05:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 17:05:47]

Dry run: This issue passed the CQ dry run.

[Thiemo Nagel, 2017-04-12 17:15:53]

tnagel@chromium.org changed reviewers:
+ achuith@chromium.org

[Thiemo Nagel, 2017-04-12 17:15:54]

Hi Achuith,

this is the split-off from the other CL.  Could you please take a look?

Thank you,
Thiemo

[achuithb, 2017-04-12 21:09:03]

Does FRE make sense on non-official builds? Is this an AD thing?

lgtm.

https://codereview.chromium.org/2816763002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/wizard_controller.cc (right):

https://codereview.chromium.org/2816763002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/wizard_controller.cc:672: OnEulaAccepted();
Maybe call this out in the CL description. Something like:
Explicitly call OnEulaAccepted for non-official builds.

[Thiemo Nagel, 2017-04-13 04:14:22]

Description was changed from

==========
Allow manual testing of FRE on Linux builds

Small refactoring of WizardController::OnNetworkConnected() to merge the
flows of official and inofficial builds as much as possible to properly
trigger FRE on a Linux build.

BUG=703658
==========

to

==========
Allow manual testing of FRE on Linux builds

Small refactoring of WizardController::OnNetworkConnected() to merge the
flows of official and unofficial builds as much as possible to properly
trigger FRE on a Linux build.  This is done by calling OnEulaAccepted()
on unofficial builds.

BUG=703658
==========

[Thiemo Nagel, 2017-04-13 04:18:22]

Thank you!

On 2017/04/12 21:09:03, achuithb wrote:
> Does FRE make sense on non-official builds?

It's very useful to be able to test it on non-official builds.  It's still
disabled by default, but after this CL has landed, it is possible to specify
--enterprise-enable-forced-re-enrollment=always to trigger it.

> Is this an AD thing?

Not related to AD other than the lack of manual testability was encountered
while fixing an AD issue.

[Thiemo Nagel, 2017-04-13 04:18:34]

https://codereview.chromium.org/2816763002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/wizard_controller.cc (right):

https://codereview.chromium.org/2816763002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/wizard_controller.cc:672: OnEulaAccepted();
On 2017/04/12 21:09:03, achuithb wrote:
> Maybe call this out in the CL description. Something like:
> Explicitly call OnEulaAccepted for non-official builds.

Done.

[Thiemo Nagel, 2017-04-13 04:18:54]

The CQ bit was checked by tnagel@chromium.org

[commit-bot: I haz the power, 2017-04-13 04:19:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 04:41:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492057134705210, "parent_rev":
"4b44200a3a78e42f34af7f888ebb6e68ee7b1687", "commit_rev":
"d0605bc9ca32f07f098363e0b1dc7d5a9bc075e8"}

[commit-bot: I haz the power, 2017-04-13 04:42:33]

Description was changed from

==========
Allow manual testing of FRE on Linux builds

Small refactoring of WizardController::OnNetworkConnected() to merge the
flows of official and unofficial builds as much as possible to properly
trigger FRE on a Linux build.  This is done by calling OnEulaAccepted()
on unofficial builds.

BUG=703658
==========

to

==========
Allow manual testing of FRE on Linux builds

Small refactoring of WizardController::OnNetworkConnected() to merge the
flows of official and unofficial builds as much as possible to properly
trigger FRE on a Linux build.  This is done by calling OnEulaAccepted()
on unofficial builds.

BUG=703658

Review-Url: https://codereview.chromium.org/2816763002
Cr-Commit-Position: refs/heads/master@{#464296}
Committed:
https://chromium.googlesource.com/chromium/src/+/d0605bc9ca32f07f098363e0b1dc...
==========

[commit-bot: I haz the power, 2017-04-13 04:42:34]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d0605bc9ca32f07f098363e0b1dc...