Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2816743006:
[Mac] Fullscreen Touch Bar Support (Closed)
|
Created:
3 years, 8 months ago by spqchan Modified:
3 years, 7 months ago Reviewers:
Robert Sesek CC:
chromium-reviews, srahim+watch_chromium.org, mac-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[Mac] Fullscreen Touch Bar Support
When in tab fullscreen, replace the ESC button with "Exit Fullscreen"
and display the origin URL of the tab content in the Touch Bar.
A test for this is added in BrowserTouchBarUnitTest
BUG=690611
Review-Url: https://codereview.chromium.org/2816743006
Cr-Commit-Position: refs/heads/master@{#468099}
Committed: https://chromium.googlesource.com/chromium/src/+/b6d37d2e75d890832ab6f473eba2283c74468fb5
Patch Set 1 #Patch Set 2 : nit #Patch Set 3 : Fixed tests #Patch Set 4 : Added origin label #Patch Set 5 : Rebased #
Total comments: 15
Patch Set 6 : Fixes for rsesek #Patch Set 7 : Added a comment #Patch Set 8 : Moved ScopedFeatureList #
Messages
Total messages: 49 (41 generated)
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:20001) has been deleted
Patchset #2 (id:40001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [Mac] Exit Fullscreen Touch Bar Button BUG= ========== to ========== [Mac] Fullscreen Touch Bar Support When in tab fullscreen, replace the ESC button with "Exit Fullscreen" and display the origin URL of the tab content in the Touch Bar. A test for this is added in BrowserTouchBarUnitTest BUG=690611 ==========
Patchset #4 (id:100001) has been deleted
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
spqchan@chromium.org changed reviewers: + rsesek@chromium.org
PTAL
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
https://codereview.chromium.org/2816743006/diff/140001/chrome/browser/ui/coco... File chrome/browser/ui/cocoa/browser_window_touch_bar.mm (right): https://codereview.chromium.org/2816743006/diff/140001/chrome/browser/ui/coco... chrome/browser/ui/cocoa/browser_window_touch_bar.mm:229: if ([bwc_ isFullscreenForTabContentOrExtension]) { Comment above this line to describe the 'why'. https://codereview.chromium.org/2816743006/diff/140001/chrome/browser/ui/coco... chrome/browser/ui/cocoa/browser_window_touch_bar.mm:231: (setEscapeKeyReplacementItemIdentifier:)]) { nit: can you fix clang-format's work here (break after : rather than before ( ) https://codereview.chromium.org/2816743006/diff/140001/chrome/browser/ui/coco... chrome/browser/ui/cocoa/browser_window_touch_bar.mm:331: int hostLength = originUrl.host().length(); int -> size_t for lengths https://codereview.chromium.org/2816743006/diff/140001/chrome/browser/ui/coco... chrome/browser/ui/cocoa/browser_window_touch_bar.mm:332: NSMutableAttributedString* attributedString = Prefer scoped_nsobject to local autoreleases. https://codereview.chromium.org/2816743006/diff/140001/chrome/browser/ui/coco... File chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm (right): https://codereview.chromium.org/2816743006/diff/140001/chrome/browser/ui/coco... chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm:22: NSString* GetTouchBarId(NSString* const touch_bar_id) { How about exposing GetTouchBarId as +[BrowserWindowTouchBar touchBarIDForItemID:] so that the logic isn't duplicated? https://codereview.chromium.org/2816743006/diff/140001/chrome/browser/ui/coco... chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm:61: base::test::ScopedFeatureList feature_list; Move this into SetUp as well? https://codereview.chromium.org/2816743006/diff/140001/chrome/browser/ui/coco... chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm:74: NSTouchBar* touchBar = [browserWindowTouchBar_ makeTouchBar]; naming: under_scores in C++
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL https://codereview.chromium.org/2816743006/diff/140001/chrome/browser/ui/coco... File chrome/browser/ui/cocoa/browser_window_touch_bar.mm (right): https://codereview.chromium.org/2816743006/diff/140001/chrome/browser/ui/coco... chrome/browser/ui/cocoa/browser_window_touch_bar.mm:229: if ([bwc_ isFullscreenForTabContentOrExtension]) { On 2017/04/27 19:05:51, Robert Sesek wrote: > Comment above this line to describe the 'why'. Done. https://codereview.chromium.org/2816743006/diff/140001/chrome/browser/ui/coco... chrome/browser/ui/cocoa/browser_window_touch_bar.mm:231: (setEscapeKeyReplacementItemIdentifier:)]) { On 2017/04/27 19:05:51, Robert Sesek wrote: > nit: can you fix clang-format's work here (break after : rather than before ( ) Done. https://codereview.chromium.org/2816743006/diff/140001/chrome/browser/ui/coco... chrome/browser/ui/cocoa/browser_window_touch_bar.mm:331: int hostLength = originUrl.host().length(); On 2017/04/27 19:05:51, Robert Sesek wrote: > int -> size_t for lengths Done. https://codereview.chromium.org/2816743006/diff/140001/chrome/browser/ui/coco... chrome/browser/ui/cocoa/browser_window_touch_bar.mm:332: NSMutableAttributedString* attributedString = On 2017/04/27 19:05:51, Robert Sesek wrote: > Prefer scoped_nsobject to local autoreleases. Done. https://codereview.chromium.org/2816743006/diff/140001/chrome/browser/ui/coco... File chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm (right): https://codereview.chromium.org/2816743006/diff/140001/chrome/browser/ui/coco... chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm:22: NSString* GetTouchBarId(NSString* const touch_bar_id) { On 2017/04/27 19:05:51, Robert Sesek wrote: > How about exposing GetTouchBarId as +[BrowserWindowTouchBar > touchBarIDForItemID:] so that the logic isn't duplicated? Done. https://codereview.chromium.org/2816743006/diff/140001/chrome/browser/ui/coco... chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm:61: base::test::ScopedFeatureList feature_list; On 2017/04/27 19:05:51, Robert Sesek wrote: > Move this into SetUp as well? I've already tried. It'll only scoped up to the end of SetUp() https://codereview.chromium.org/2816743006/diff/140001/chrome/browser/ui/coco... chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm:74: NSTouchBar* touchBar = [browserWindowTouchBar_ makeTouchBar]; On 2017/04/27 19:05:51, Robert Sesek wrote: > naming: under_scores in C++ Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM https://codereview.chromium.org/2816743006/diff/140001/chrome/browser/ui/coco... File chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm (right): https://codereview.chromium.org/2816743006/diff/140001/chrome/browser/ui/coco... chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm:61: base::test::ScopedFeatureList feature_list; On 2017/04/28 16:36:04, spqchan wrote: > On 2017/04/27 19:05:51, Robert Sesek wrote: > > Move this into SetUp as well? > > I've already tried. It'll only scoped up to the end of SetUp() You'd have to make the ScopedFeatureList a member of the test itself.
On 2017/04/28 17:18:04, Robert Sesek wrote: > LGTM > > https://codereview.chromium.org/2816743006/diff/140001/chrome/browser/ui/coco... > File chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm (right): > > https://codereview.chromium.org/2816743006/diff/140001/chrome/browser/ui/coco... > chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm:61: > base::test::ScopedFeatureList feature_list; > On 2017/04/28 16:36:04, spqchan wrote: > > On 2017/04/27 19:05:51, Robert Sesek wrote: > > > Move this into SetUp as well? > > > > I've already tried. It'll only scoped up to the end of SetUp() > > You'd have to make the ScopedFeatureList a member of the test itself. Doh, can't believe I missed that. Thanks for pointing it out!
The CQ bit was checked by spqchan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org Link to the patchset: https://codereview.chromium.org/2816743006/#ps200001 (title: "Moved ScopedFeatureList")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 200001, "attempt_start_ts": 1493403979753630,
"parent_rev": "20c0b3059ef47f07a3e09e40f1dcc167da4817d8", "commit_rev":
"b6d37d2e75d890832ab6f473eba2283c74468fb5"}
Message was sent while issue was closed.
Description was changed from ========== [Mac] Fullscreen Touch Bar Support When in tab fullscreen, replace the ESC button with "Exit Fullscreen" and display the origin URL of the tab content in the Touch Bar. A test for this is added in BrowserTouchBarUnitTest BUG=690611 ========== to ========== [Mac] Fullscreen Touch Bar Support When in tab fullscreen, replace the ESC button with "Exit Fullscreen" and display the origin URL of the tab content in the Touch Bar. A test for this is added in BrowserTouchBarUnitTest BUG=690611 Review-Url: https://codereview.chromium.org/2816743006 Cr-Commit-Position: refs/heads/master@{#468099} Committed: https://chromium.googlesource.com/chromium/src/+/b6d37d2e75d890832ab6f473eba2... ==========
Message was sent while issue was closed.
Committed patchset #8 (id:200001) as https://chromium.googlesource.com/chromium/src/+/b6d37d2e75d890832ab6f473eba2...
Message was sent while issue was closed.
A revert of this CL (patchset #8 id:200001) has been created in https://codereview.chromium.org/2875293003/ by spqchan@chromium.org. The reason for reverting is: Potentially caused a crash: crbug.com/717922. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
